Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2618773004: Remove ContextClient from NavigatorGeolocation (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org, haraken, timvolodine, mvanouwerkerk+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextClient from NavigatorGeolocation Now that Navigator's supplement can get a Navigator object via host(). Then Navigator's supplement doesn't need to observe ContextClient. BUG=610176 Review-Url: https://codereview.chromium.org/2618773004 Cr-Commit-Position: refs/heads/master@{#441893} Committed: https://chromium.googlesource.com/chromium/src/+/8b5d6d41bd50a323fd9e0cca5920548b34f6add6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.h View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.cpp View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-06 01:16:41 UTC) #2
sof
lgtm
3 years, 11 months ago (2017-01-06 06:15:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618773004/1
3 years, 11 months ago (2017-01-06 06:25:34 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 06:34:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8b5d6d41bd50a323fd9e0cca5920...

Powered by Google App Engine
This is Rietveld 408576698