Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 2618753002: Revert of Prefer using ContextClient over ContextLifecycleObserver (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof, dcheng
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-css, tzik, eric.carlson_apple.com, dglazkov+blink, apavlov+blink_chromium.org, nhiroki, cmumford, darktears, blink-reviews, Srirama, jsbell+idb_chromium.org, kinuko+fileapi, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prefer using ContextClient over ContextLifecycleObserver (patchset #1 id:1 of https://codereview.chromium.org/2607533002/ ) Reason for revert: This CL caused a flaky failure: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__dbg_/6744/layout-test-results/storage/indexeddb/observer-workers-crash-log.txt Original issue's description: > Prefer using ContextClient over ContextLifecycleObserver > > ContextClient is more lightweight than ContextLifecycleObserver. > Classes that don't override contextDestroyed should use ContextClient. > > BUG=610176 > > Committed: https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d > Cr-Commit-Position: refs/heads/master@{#440822} TBR=dcheng@chromium.org,sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=610176 Review-Url: https://codereview.chromium.org/2618753002 Cr-Commit-Position: refs/heads/master@{#441696} Committed: https://chromium.googlesource.com/chromium/src/+/9d5d32b6a54f1f483fb0342a4be35ab974684d63

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
haraken
Created Revert of Prefer using ContextClient over ContextLifecycleObserver
3 years, 11 months ago (2017-01-05 15:52:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618753002/1
3 years, 11 months ago (2017-01-05 15:53:03 UTC) #3
sof
lgtm, thanks - only IDBTransaction would be running into this worker issue, i think.
3 years, 11 months ago (2017-01-05 16:37:03 UTC) #4
jsbell
On 2017/01/05 16:37:03, sof wrote: > lgtm, thanks - only IDBTransaction would be running into ...
3 years, 11 months ago (2017-01-05 17:38:18 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:50:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d5d32b6a54f1f483fb0342a4be3...

Powered by Google App Engine
This is Rietveld 408576698