Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2618743004:
[wasm] some const annotations (Closed)
|
Created:
3 years, 11 months ago by Mircea Trofin Modified:
3 years, 11 months ago Reviewers:
bradnelson CC:
v8-reviews_googlegroups.com, titzer Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] some const annotations
BUG=
Review-Url: https://codereview.chromium.org/2618743004
Cr-Commit-Position: refs/heads/master@{#42110}
Committed: https://chromium.googlesource.com/v8/v8/+/2c60a1facf13fed597fcdc30b53d34ec13d44927
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 18 (12 generated)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] some const annotations BUG= ========== to ========== [wasm] some const annotations BUG= ==========
mtrofin@chromium.org changed reviewers: + bradnelson@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bradnelson@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for src/wasm/decoder.h:
While running git apply --index -p1;
error: patch failed: src/wasm/decoder.h:283
error: src/wasm/decoder.h: patch does not apply
Patch: src/wasm/decoder.h
Index: src/wasm/decoder.h
diff --git a/src/wasm/decoder.h b/src/wasm/decoder.h
index
fc8f110b733f93e3eb9693b92cf7eb598aa0f794..67b93694e1f95b6a2460e457a6e914ed63bba8db
100644
--- a/src/wasm/decoder.h
+++ b/src/wasm/decoder.h
@@ -283,9 +283,9 @@ class Decoder {
bool failed() const { return !ok(); }
bool more() const { return pc_ < limit_; }
- const byte* start() { return start_; }
- const byte* pc() { return pc_; }
- uint32_t pc_offset() { return static_cast<uint32_t>(pc_ - start_); }
+ const byte* start() const { return start_; }
+ const byte* pc() const { return pc_; }
+ uint32_t pc_offset() const { return static_cast<uint32_t>(pc_ - start_); }
protected:
const byte* start_;
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2618743004/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483719442470320,
"parent_rev": "677bd40ea6f4ab1babe24168443115451fbec3a2", "commit_rev":
"2c60a1facf13fed597fcdc30b53d34ec13d44927"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] some const annotations BUG= ========== to ========== [wasm] some const annotations BUG= Review-Url: https://codereview.chromium.org/2618743004 Cr-Commit-Position: refs/heads/master@{#42110} Committed: https://chromium.googlesource.com/v8/v8/+/2c60a1facf13fed597fcdc30b53d34ec13d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/2c60a1facf13fed597fcdc30b53d34ec13d... |
