runtime/bin/process_android.cc - Issue 2618723002: Workaround attempt for timeout flakiness: Avoid running atexit() handlers in fork()ed process on li…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/process_android.cc

Issue 2618723002: Workaround attempt for timeout flakiness: Avoid running atexit() handlers in fork()ed process on li… (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/process_android.cc

diff --git a/runtime/bin/process_android.cc b/runtime/bin/process_android.cc

index 550f680a0861d9894b2557149f7d139ed65119fe..5fe72147b3c33cc188251bae78b4cfd7ed87d887 100644

--- a/runtime/bin/process_android.cc

+++ b/runtime/bin/process_android.cc

@@ -165,7 +165,7 @@ class ExitCodeHandler {

// Fork to wake up waitpid.

if (TEMP_FAILURE_RETRY(fork()) == 0) {

- exit(0);

+ _exit(0);

Vyacheslav Egorov (Google) 2017/01/05 12:43:37 Please leave a comment here why _exit and not exit

kustermann 2017/01/05 12:55:34 Done.

}

monitor_->Notify();

« no previous file with comments | « no previous file | runtime/bin/process_linux.cc » ('j') | runtime/bin/process_linux.cc » ('J')