Workaround attempt for timeout flakiness: Avoid running atexit() handlers in fork()ed process on li…

runtime/bin/process_android.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if !defined(DART_IO_DISABLED)
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_ANDROID)
 
 #include "bin/process.h"
@@ skipping 147 matching lines @@
     if (!running_) {
       return;
     }
 
     // Set terminate_done_ to false, so we can use it as a guard for our
     // monitor.
     running_ = false;
 
     // Fork to wake up waitpid.
     if (TEMP_FAILURE_RETRY(fork()) == 0) {
-      exit(0);
+      _exit(0);

[Vyacheslav Egorov (Google), 2017/01/05 12:43:37]

Please leave a comment here why _exit and not exit.

[kustermann, 2017/01/05 12:55:34]

Done.

     }
 
     monitor_->Notify();
 
     while (!terminate_done_) {
       monitor_->Wait(Monitor::kNoTimeout);
     }
   }
 
  private:
@@ skipping 811 matching lines @@
     VOID_NO_RETRY_EXPECTED(sigaction(signal, &act, NULL));
   }
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_ANDROID)
 
 #endif  // !defined(DART_IO_DISABLED)