Remove ContextClient from NavigatorVR

Remove ContextClient from NavigatorVR

Now that Navigator supplements can get the Navigator object via host(),
the supplements don't need to observe ContextClient.

BUG=610176
Review-Url: https://codereview.chromium.org/2618713002
Cr-Commit-Position: refs/heads/master@{#441828}
Committed: https://chromium.googlesource.com/chromium/src/+/8ccc1dabf359da95ac44b4b012624dd6d2f53001

[haraken, 2017-01-05 11:56:17]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-01-05 11:56:18]

PTAL

[sof, 2017-01-05 12:10:40]

https://codereview.chromium.org/2618713002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):

https://codereview.chromium.org/2618713002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:95: :
PageVisibilityObserver(frame->page()) {
I'll let you follow up
https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
before I take a look at this series of CLs.

[haraken, 2017-01-05 12:20:36]

On 2017/01/05 12:10:40, sof wrote:
>
https://codereview.chromium.org/2618713002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):
> 
>
https://codereview.chromium.org/2618713002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:95: :
> PageVisibilityObserver(frame->page()) {
> I'll let you follow up
>
https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
> before I take a look at this series of CLs.

Sorry, fixed in PS2.

[sof, 2017-01-05 12:47:59]

https://codereview.chromium.org/2618713002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):

https://codereview.chromium.org/2618713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:53: if (!document() ||
!controller()) {
Why is the !controller() part needed?

https://codereview.chromium.org/2618713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:115: UserGestureIndicator
gestureIndicator(
isn't there a "if (!window) return;" missing here?

[haraken, 2017-01-05 13:08:19]

On 2017/01/05 12:47:59, sof wrote:
>
https://codereview.chromium.org/2618713002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):
> 
>
https://codereview.chromium.org/2618713002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:53: if (!document() ||
> !controller()) {
> Why is the !controller() part needed?

Removed.

> 
>
https://codereview.chromium.org/2618713002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:115: UserGestureIndicator
> gestureIndicator(
> isn't there a "if (!window) return;" missing here?

Done.

[sof, 2017-01-05 13:22:28]

lgtm %

https://codereview.chromium.org/2618713002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):

https://codereview.chromium.org/2618713002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:113: if (host()->frame())
if (!host()->frame())

https://codereview.chromium.org/2618713002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:117: LocalDOMWindow* window
= host()->frame()->domWindow();
DCHECK (or comment) against non-obvious non-nullness would be useful; i.e., a
NavigatorVR cannot be constructed without a |domWindow()|, and it isn't
subsequently cleared on the frame, so it must be non-null.

[haraken, 2017-01-05 23:59:26]

>
https://codereview.chromium.org/2618713002/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):
> 
>
https://codereview.chromium.org/2618713002/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:113: if (host()->frame())
> if (!host()->frame())
> 
>
https://codereview.chromium.org/2618713002/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:117: LocalDOMWindow*
window
> = host()->frame()->domWindow();
> DCHECK (or comment) against non-obvious non-nullness would be useful; i.e., a
> NavigatorVR cannot be constructed without a |domWindow()|, and it isn't
> subsequently cleared on the frame, so it must be non-null.

Done.

[haraken, 2017-01-05 23:59:48]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-01-05 23:59:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2618713002/#ps140001
(title: "temp")

[commit-bot: I haz the power, 2017-01-06 00:00:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:21:14]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1483660788848020,
"parent_rev": "0955147b8de3c2dd81b68aedb92872aaf418fc2b", "commit_rev":
"8ccc1dabf359da95ac44b4b012624dd6d2f53001"}

[commit-bot: I haz the power, 2017-01-06 02:21:42]

Description was changed from

==========
Remove ContextClient from NavigatorVR

Now that Navigator supplements can get the Navigator object via host(),
the supplements don't need to observe ContextClient.

BUG=610176
==========

to

==========
Remove ContextClient from NavigatorVR

Now that Navigator supplements can get the Navigator object via host(),
the supplements don't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2618713002
Cr-Commit-Position: refs/heads/master@{#441828}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ccc1dabf359da95ac44b4b01262...
==========

[commit-bot: I haz the power, 2017-01-06 02:21:43]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/8ccc1dabf359da95ac44b4b01262...