Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2618693003: Fix logic for retrying BattOr initialization after a timeout (Closed)

Created:
3 years, 11 months ago by charliea (OOO until 10-5)
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix logic for retrying BattOr initialization after a timeout Unfortunately, due to the way this code relies on posting a delayed tasks that gets run at a later time, writing a unit test is very difficult. BUG=678659 Review-Url: https://codereview.chromium.org/2618693003 Cr-Commit-Position: refs/heads/master@{#441770} Committed: https://chromium.googlesource.com/chromium/src/+/a3e1e654c70726bbf429fb8a3f75e9956c78a037

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/battor_agent/battor_agent.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
charliea (OOO until 10-5)
3 years, 11 months ago (2017-01-05 19:46:23 UTC) #7
rnephew (Reviews Here)
On 2017/01/05 19:46:23, charliea wrote: lgtm
3 years, 11 months ago (2017-01-05 20:57:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618693003/40001
3 years, 11 months ago (2017-01-05 22:10:59 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 22:17:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a3e1e654c70726bbf429fb8a3f75...

Powered by Google App Engine
This is Rietveld 408576698