Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2618683002: Http Bad: Remove locale parameter in 'Learn more' link url (Closed)

Created:
3 years, 11 months ago by lshang
Modified:
3 years, 11 months ago
Reviewers:
Mathieu, Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, sebsg+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, mathp+autofillwatch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Http Bad: Remove locale parameter in 'Learn more' link url So that browser can redirect it to the help center page in different language. BUG=678400 Review-Url: https://codereview.chromium.org/2618683002 Cr-Commit-Position: refs/heads/master@{#441644} Committed: https://chromium.googlesource.com/chromium/src/+/873d4ac7f893b5f84702a5fe5787045e82b1047a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
lshang
PTAL thanks!
3 years, 11 months ago (2017-01-05 10:07:46 UTC) #4
Mathieu
lgtm
3 years, 11 months ago (2017-01-05 12:44:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618683002/1
3 years, 11 months ago (2017-01-05 12:45:06 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 13:25:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/873d4ac7f893b5f84702a5fe5787...

Powered by Google App Engine
This is Rietveld 408576698