Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2618633005: Don't explode if --tools or --extra-tools isn't specified. (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't explode if --tools or --extra-tools isn't specified. BUG=none Review-Url: https://codereview.chromium.org/2618633005 Cr-Commit-Position: refs/heads/master@{#441846} Committed: https://chromium.googlesource.com/chromium/src/+/31b6c46900ec8e64ecdf6d288950b31dcd2dd1c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
dcheng
Oops. =(
3 years, 11 months ago (2017-01-05 23:04:54 UTC) #2
danakj
LGTM
3 years, 11 months ago (2017-01-05 23:06:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618633005/1
3 years, 11 months ago (2017-01-05 23:07:38 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:46:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/31b6c46900ec8e64ecdf6d288950...

Powered by Google App Engine
This is Rietveld 408576698