Auto-enable Physical Web for appropriate users

Auto-enable Physical Web for appropriate users

Now that the Physical Web no longer displays notifications, the
opt-in notification will not fire.  Instead, users can enable the
Physical Web manually, or if they have Google search enabled (i.e.,
they are already sending info to Google for omnibox results).  Note
that this is the same behavior as on iOS.

BUG=663842
Review-Url: https://codereview.chromium.org/2618613007
Cr-Commit-Position: refs/heads/master@{#443128}
Committed: https://chromium.googlesource.com/chromium/src/+/5d0bae6b0cf3d23a1b4d6a56e34ed015cfa82989

[cco3, 2017-01-07 00:09:56]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[mattreynolds, 2017-01-07 00:31:12]

lgtm

[cco3, 2017-01-07 00:33:32]

cco3@chromium.org changed reviewers:
+ dtrainor@chromium.org

[cco3, 2017-01-07 00:33:33]

Hi David, would you be able to review this change?

[mmocny, 2017-01-09 15:43:11]

mmocny@chromium.org changed reviewers:
+ mmocny@chromium.org

[mmocny, 2017-01-09 15:43:11]

lgtm

https://codereview.chromium.org/2618613007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
(right):

https://codereview.chromium.org/2618613007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:132:
if (featureIsEnabled() && isPhysicalWebPreferenceEnabled()) {
Nit: featureIsEnabled() is redundant now, since you check for it at the start.

[David Trainor- moved to gerrit, 2017-01-09 22:20:28]

lgtm

[cco3, 2017-01-11 19:27:34]

Hi David, would you be able to review this change?

[cco3, 2017-01-11 19:29:49]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-11 19:29:50]

The patchset sent to the CQ was uploaded after l-g-t-m from mmocny@chromium.org,
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2618613007/#ps20001
(title: "Remove unnecessary feature check")

[cco3, 2017-01-11 19:30:11]

Whoops, didn't mean to send that...

[commit-bot: I haz the power, 2017-01-11 19:30:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:49:41]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[cco3, 2017-01-12 00:26:31]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-12 00:26:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, mmocny@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2618613007/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-12 00:27:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:53:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484180791377790,
"parent_rev": "4d26738f00698ad57b12bf969251513b5260f954", "commit_rev":
"5d0bae6b0cf3d23a1b4d6a56e34ed015cfa82989"}

[commit-bot: I haz the power, 2017-01-12 02:53:41]

Description was changed from

==========
Auto-enable Physical Web for appropriate users

Now that the Physical Web no longer displays notifications, the
opt-in notification will not fire.  Instead, users can enable the
Physical Web manually, or if they have Google search enabled (i.e.,
they are already sending info to Google for omnibox results).  Note
that this is the same behavior as on iOS.

BUG=663842
==========

to

==========
Auto-enable Physical Web for appropriate users

Now that the Physical Web no longer displays notifications, the
opt-in notification will not fire.  Instead, users can enable the
Physical Web manually, or if they have Google search enabled (i.e.,
they are already sending info to Google for omnibox results).  Note
that this is the same behavior as on iOS.

BUG=663842

Review-Url: https://codereview.chromium.org/2618613007
Cr-Commit-Position: refs/heads/master@{#443128}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d0bae6b0cf3d23a1b4d6a56e34e...
==========

[commit-bot: I haz the power, 2017-01-12 02:53:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5d0bae6b0cf3d23a1b4d6a56e34e...