Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 2618613006: Remove ContextClient from DOMWindowSpeechSynthesis (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextClient from DOMWindowSpeechSynthesis If we pass in ScriptState to DOMWindowSpeechSynthesis::speechSynthesis, DOMWindowSpeechSynthesis doesn't need to observe ContextClient. BUG=610176 Review-Url: https://codereview.chromium.org/2618613006 Cr-Commit-Position: refs/heads/master@{#441918} Committed: https://chromium.googlesource.com/chromium/src/+/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Patch Set 4 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -38 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-boundary-events.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-cancel.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-cancel-twice.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-gc-utterance-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-mock-no-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-speak.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-speak-invalid-argument-throws.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-speak-multiple.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-utterance-basics.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-utterance-voice.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-voices.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-voices-changed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/DOMWindowSpeechSynthesis.h View 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/DOMWindowSpeechSynthesis.cpp View 3 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/WindowSpeechSynthesis.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/testing/InternalsSpeechSynthesis.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/testing/InternalsSpeechSynthesis.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/testing/InternalsSpeechSynthesis.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-06 02:16:14 UTC) #2
sof
lgtm; some "detached frame" test expectations needs to be updated.
3 years, 11 months ago (2017-01-06 07:45:59 UTC) #7
haraken
On 2017/01/06 07:45:59, sof wrote: > lgtm; some "detached frame" test expectations needs to be ...
3 years, 11 months ago (2017-01-06 08:04:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618613006/60001
3 years, 11 months ago (2017-01-06 08:05:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/343435)
3 years, 11 months ago (2017-01-06 09:51:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618613006/60001
3 years, 11 months ago (2017-01-06 09:58:39 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 11:09:39 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7e483a01fa3b74f5dc5ecf16079b...

Powered by Google App Engine
This is Rietveld 408576698