Roll material_components_ios & material_roboto_font_loader_ios.

Roll material_components_ios & material_roboto_font_loader_ios.

Roll material_components_ios to v19.0.0 (079c1c9a) and
material_roboto_font_loader_ios to v1.1.1 (e9b8647).

Add a workaround to allow compilation of material_roboto_font_loader_ios
until upstream fixes the incorrect #import path (see [1] for tupstream issue).

[1]: https://github.com/material-foundation/material-roboto-font-loader-ios/issues/6

BUG=673904
Review-Url: https://codereview.chromium.org/2618583004
Cr-Commit-Position: refs/heads/master@{#441936}
Committed: https://chromium.googlesource.com/chromium/src/+/a5d5f1073b5f36c118b80e7629f89876929e2eda

[sdefresne, 2017-01-06 12:59:09]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 12:59:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-06 13:00:12]

sdefresne@chromium.org changed reviewers:
+ lpromero@chromium.org

[sdefresne, 2017-01-06 13:00:12]

Please take a look.

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_co...
File ios/third_party/material_components_ios/BUILD.gn (left):

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_co...
ios/third_party/material_components_ios/BUILD.gn:272: # TODO(crbug.com/673904):
remove when the migration to MDFRobotoFontLoader
I'll need to rebase to remove this change.

[lpromero, 2017-01-06 13:06:09]

lgtm

Thank you!

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
File ios/third_party/material_roboto_font_loader_ios/BUILD.gn (right):

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
ios/third_party/material_roboto_font_loader_ios/BUILD.gn:5: # Version v1.1.1 of
material_components_ios uses a cocoa pod path to access
CocoaPods

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
ios/third_party/material_roboto_font_loader_ios/BUILD.gn:8: # code has been
fixed.
Add TODO(crbug.com/673904)

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
File
ios/third_party/material_roboto_font_loader_ios/local_src/MaterialComponents/MaterialTypography.h
(right):

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
ios/third_party/material_roboto_font_loader_ios/local_src/MaterialComponents/MaterialTypography.h:8:
// Version v1.1.1 of material_components_ios uses a cocoa pod path to access
CocoaPods

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
ios/third_party/material_roboto_font_loader_ios/local_src/MaterialComponents/MaterialTypography.h:13:
// (otherwise the current file would be included as #import "" first seach
s/seach/search, but I don't understand the sentence. s/first/for?

[sdefresne, 2017-01-06 13:14:18]

Patchset #3 (id:40001) has been deleted

[sdefresne, 2017-01-06 13:15:30]

Thank you for the review.

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
File ios/third_party/material_roboto_font_loader_ios/BUILD.gn (right):

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
ios/third_party/material_roboto_font_loader_ios/BUILD.gn:5: # Version v1.1.1 of
material_components_ios uses a cocoa pod path to access
On 2017/01/06 13:06:08, lpromero wrote:
> CocoaPods

Done.

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
ios/third_party/material_roboto_font_loader_ios/BUILD.gn:8: # code has been
fixed.
On 2017/01/06 13:06:08, lpromero wrote:
> Add TODO(crbug.com/673904)

Done.

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
File
ios/third_party/material_roboto_font_loader_ios/local_src/MaterialComponents/MaterialTypography.h
(right):

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
ios/third_party/material_roboto_font_loader_ios/local_src/MaterialComponents/MaterialTypography.h:8:
// Version v1.1.1 of material_components_ios uses a cocoa pod path to access
On 2017/01/06 13:06:08, lpromero wrote:
> CocoaPods

Done.

https://codereview.chromium.org/2618583004/diff/1/ios/third_party/material_ro...
ios/third_party/material_roboto_font_loader_ios/local_src/MaterialComponents/MaterialTypography.h:13:
// (otherwise the current file would be included as #import "" first seach
On 2017/01/06 13:06:08, lpromero wrote:
> s/seach/search, but I don't understand the sentence. s/first/for?

Rewrote the comment.

[sdefresne, 2017-01-06 13:15:33]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-01-06 13:15:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2618583004/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-01-06 13:15:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-06 14:49:23]

Description was changed from

==========
Roll material_components_ios & material_roboto_font_loader_ios.

Roll material_components_ios to v19.0.0 (079c1c9a) and
material_roboto_font_loader_ios to v1.1.1 (e9b8647).

Add a workaround to allow compilation of material_roboto_font_loader_ios
until upstream fixes the incorrect #import path (see [1] for the pull
request to fix this).

[1]:
https://github.com/material-foundation/material-roboto-font-loader-ios/pull/7

BUG=673904
==========

to

==========
Roll material_components_ios & material_roboto_font_loader_ios.

Roll material_components_ios to v19.0.0 (079c1c9a) and
material_roboto_font_loader_ios to v1.1.1 (e9b8647).

Add a workaround to allow compilation of material_roboto_font_loader_ios
until upstream fixes the incorrect #import path (see [1] for tupstream issue).

[1]:
https://github.com/material-foundation/material-roboto-font-loader-ios/issues/6

BUG=673904
==========

[commit-bot: I haz the power, 2017-01-06 15:04:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483708533624390,
"parent_rev": "7e0ae49ce66d97e8fb353d55563b0ed040e49416", "commit_rev":
"a5d5f1073b5f36c118b80e7629f89876929e2eda"}

[commit-bot: I haz the power, 2017-01-06 15:05:06]

Description was changed from

==========
Roll material_components_ios & material_roboto_font_loader_ios.

Roll material_components_ios to v19.0.0 (079c1c9a) and
material_roboto_font_loader_ios to v1.1.1 (e9b8647).

Add a workaround to allow compilation of material_roboto_font_loader_ios
until upstream fixes the incorrect #import path (see [1] for tupstream issue).

[1]:
https://github.com/material-foundation/material-roboto-font-loader-ios/issues/6

BUG=673904
==========

to

==========
Roll material_components_ios & material_roboto_font_loader_ios.

Roll material_components_ios to v19.0.0 (079c1c9a) and
material_roboto_font_loader_ios to v1.1.1 (e9b8647).

Add a workaround to allow compilation of material_roboto_font_loader_ios
until upstream fixes the incorrect #import path (see [1] for tupstream issue).

[1]:
https://github.com/material-foundation/material-roboto-font-loader-ios/issues/6

BUG=673904

Review-Url: https://codereview.chromium.org/2618583004
Cr-Commit-Position: refs/heads/master@{#441936}
Committed:
https://chromium.googlesource.com/chromium/src/+/a5d5f1073b5f36c118b80e7629f8...
==========

[commit-bot: I haz the power, 2017-01-06 15:05:07]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a5d5f1073b5f36c118b80e7629f8...