Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2618573002: Add test to check for crash caused by stale WebContents in chrome://interstitials (Closed)

Created:
3 years, 11 months ago by meacer
Modified:
3 years, 11 months ago
Reviewers:
estark
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test to check for crash caused by stale WebContents in chrome://interstitials BUG=611706 Review-Url: https://codereview.chromium.org/2618573002 Cr-Commit-Position: refs/heads/master@{#441798} Committed: https://chromium.googlesource.com/chromium/src/+/7b1ab28d89a2ff18515b3c699dfc02a15aae84ee

Patch Set 1 #

Patch Set 2 : Fix browser side navigation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
meacer
PTAL?
3 years, 11 months ago (2017-01-04 23:55:50 UTC) #2
estark
lgtm
3 years, 11 months ago (2017-01-05 16:23:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618573002/1
3 years, 11 months ago (2017-01-05 18:27:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/365442)
3 years, 11 months ago (2017-01-05 19:26:45 UTC) #7
meacer
Looks like the test caught a new bug.
3 years, 11 months ago (2017-01-05 21:47:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618573002/20001
3 years, 11 months ago (2017-01-05 21:48:08 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 01:40:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7b1ab28d89a2ff18515b3c699dfc...

Powered by Google App Engine
This is Rietveld 408576698