Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2618563002: Skip importing domxpath/xml_xpath_runner.html due to large file. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews, dom-dev_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip importing domxpath/xml_xpath_runner.html due to large file. Currently, the large (2.2MB) file domxpath/xml_xpath_tests.xml hasn't been imported because the auto-importer can't handle it because Rietveld can't handle very large text files. The auto-importer marked this test as fail, but instead we should skip trying to import it for now since the reason why it can't be run is not a problem with the test itself, but a problem with the importer. BUG=676491 Committed: https://crrev.com/7c8e22a0a0e02013b973443aada2975d7d915e40 Cr-Commit-Position: refs/heads/master@{#441550}

Patch Set 1 #

Patch Set 2 : Remove existing file that's now skipped #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -59 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/domxpath/xml_xpath_runner.html View 1 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
qyearsley
3 years, 11 months ago (2017-01-04 23:08:24 UTC) #2
jeffcarp
lgtm
3 years, 11 months ago (2017-01-04 23:12:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618563002/1
3 years, 11 months ago (2017-01-04 23:15:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/357865)
3 years, 11 months ago (2017-01-05 00:21:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618563002/20001
3 years, 11 months ago (2017-01-05 01:02:33 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-05 01:46:16 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 01:49:35 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c8e22a0a0e02013b973443aada2975d7d915e40
Cr-Commit-Position: refs/heads/master@{#441550}

Powered by Google App Engine
This is Rietveld 408576698