Reorganize virtual/mojo-loading test expectations w/site-per-process

Reorganize virtual/mojo-loading test expectations w/site-per-process

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 670562, 610835, 678481, 678482, 678484, 678485, 678486, 678487, 678488, 678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org

Review-Url: https://codereview.chromium.org/2618523004
Cr-Commit-Position: refs/heads/master@{#441886}
Committed: https://chromium.googlesource.com/chromium/src/+/8fb8af180ee4c2a3bdd6705aa91022ce0c18dc1c

[yhirano, 2017-01-05 05:57:54]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 05:58:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-05 06:59:39]

Description was changed from

==========
Reorganize virtual/mojo-loading failure expectations w/site-per-process

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 610835, 670496, 678481, 678482, 678484, 678485, 678486, 678487,
678488, 678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org
==========

to

==========
Reorganize virtual/mojo-loading failure expectations w/site-per-process

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 610835, 678481, 678482, 678484, 678485, 678486, 678487, 678488,
678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org
==========

[yhirano, 2017-01-05 07:01:53]

yhirano@chromium.org changed reviewers:
- lukasza@chromium.org

[yhirano, 2017-01-05 07:02:10]

yhirano@chromium.org changed reviewers:
+ lukasza@chromium.org

[yhirano, 2017-01-05 07:03:25]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 07:03:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-05 07:05:06]

Description was changed from

==========
Reorganize virtual/mojo-loading failure expectations w/site-per-process

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 610835, 678481, 678482, 678484, 678485, 678486, 678487, 678488,
678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org
==========

to

==========
Reorganize virtual/mojo-loading failure expectations w/site-per-process

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 670562, 610835, 678481, 678482, 678484, 678485, 678486, 678487,
678488, 678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org
==========

[yhirano, 2017-01-05 07:08:46]

lukasza@, can you take a look? I copied expectation entries between two files
because you said FlagExpectations/site-per-process doesn't inherit
TestExpectation. Is my understanding correct?

[yhirano, 2017-01-05 07:09:05]

Description was changed from

==========
Reorganize virtual/mojo-loading failure expectations w/site-per-process

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 670562, 610835, 678481, 678482, 678484, 678485, 678486, 678487,
678488, 678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org
==========

to

==========
Reorganize virtual/mojo-loading test expectations w/site-per-process

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 670562, 610835, 678481, 678482, 678484, 678485, 678486, 678487,
678488, 678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org
==========

[commit-bot: I haz the power, 2017-01-05 09:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 09:14:50]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-01-05 17:11:45]

+site-isolation-reviews@

LGTM with one suggestion.

https://codereview.chromium.org/2618523004/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right):

https://codereview.chromium.org/2618523004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:179:
crbug.com/678499
virtual/mojo-loading/http/tests/security/contentSecurityPolicy/require-sri-for/require-sri-for-script-preload-allowed.php
[ Failure Pass ]
Thank you very much for triaging these.  Could you please split these test
expectations into 2 sections - one for site-isolation-specific failures and
another one for generic flakiness (with one-line comments describing which
section is which one)?  For example - looking at the bugs I see that
http/tests/inspector/resource-tree/resource-tree-reload.html is flaky overall,
but http/tests/inspector/appcache/appcache-iframe-manifests.html is only flaky
on site isolation bots.

[yhirano, 2017-01-06 04:49:02]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 04:49:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 04:55:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 04:55:43]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yhirano, 2017-01-06 05:10:57]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 05:11:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 05:12:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 05:12:53]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[yhirano, 2017-01-06 05:14:29]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 05:14:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 05:16:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 05:16:22]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[yhirano, 2017-01-06 05:17:23]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 05:17:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-06 05:20:30]

On 2017/01/05 17:11:45, Łukasz Anforowicz wrote:
> +site-isolation-reviews@
> 
> LGTM with one suggestion.
> 
>
https://codereview.chromium.org/2618523004/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right):
> 
>
https://codereview.chromium.org/2618523004/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:179:
> crbug.com/678499
>
virtual/mojo-loading/http/tests/security/contentSecurityPolicy/require-sri-for/require-sri-for-script-preload-allowed.php
> [ Failure Pass ]
> Thank you very much for triaging these.  Could you please split these test
> expectations into 2 sections - one for site-isolation-specific failures and
> another one for generic flakiness (with one-line comments describing which
> section is which one)?  For example - looking at the bugs I see that
> http/tests/inspector/resource-tree/resource-tree-reload.html is flaky overall,
> but http/tests/inspector/appcache/appcache-iframe-manifests.html is only flaky
> on site isolation bots.

Thanks!

As FlagExpectations/site-per-process does seem inherit TestExpectations, I
removed entries listed in TestExpectations and leave entries listed in
SlowTests.

[yhirano, 2017-01-06 05:20:36]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2017-01-06 05:20:37]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2017-01-06 05:20:37]

The patchset sent to the CQ was uploaded after l-g-t-m from lukasza@chromium.org
Link to the patchset: https://codereview.chromium.org/2618523004/#ps100001
(title: "fix")

[commit-bot: I haz the power, 2017-01-06 05:20:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-06 05:21:16]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2017-01-06 05:21:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 06:15:51]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1483680076283480,
"parent_rev": "41d8555158262926a0971b6f40da9988f80e6c55", "commit_rev":
"8fb8af180ee4c2a3bdd6705aa91022ce0c18dc1c"}

[commit-bot: I haz the power, 2017-01-06 06:16:20]

Description was changed from

==========
Reorganize virtual/mojo-loading test expectations w/site-per-process

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 670562, 610835, 678481, 678482, 678484, 678485, 678486, 678487,
678488, 678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org
==========

to

==========
Reorganize virtual/mojo-loading test expectations w/site-per-process

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 670562, 610835, 678481, 678482, 678484, 678485, 678486, 678487,
678488, 678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org

Review-Url: https://codereview.chromium.org/2618523004
Cr-Commit-Position: refs/heads/master@{#441886}
Committed:
https://chromium.googlesource.com/chromium/src/+/8fb8af180ee4c2a3bdd6705aa910...
==========

[commit-bot: I haz the power, 2017-01-06 06:16:21]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8fb8af180ee4c2a3bdd6705aa910...