third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp - Issue 2618443002: Remove use of legacy SkFontMgr factories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

Issue 2618443002: Remove use of legacy SkFontMgr factories. (Closed)

Patch Set: Address comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

index ed5c3ec71cfdfac6d5cdeeb0651f4971482a9550..8aebb5ec7a2b4c05588de38e1b7365522820ebda 100644

--- a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

+++ b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

@@ -104,7 +104,7 @@ void FontCache::setStatusFontMetrics(const wchar_t* familyName,

FontCache::FontCache() : m_purgePreventCount(0) {

m_fontManager = sk_ref_sp(s_staticFontManager);

if (!m_fontManager)

- m_fontManager.reset(SkFontMgr_New_DirectWrite());

+ m_fontManager = SkFontMgr_New_DirectWrite();

ASSERT(m_fontManager.get());

}