Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/child/font_warmup_win.h

Issue 2618443002: Remove use of legacy SkFontMgr factories. (Closed)
Patch Set: Address comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc ('k') | content/child/font_warmup_win.cc » ('j') | third_party/WebKit/public/web/win/WebFontRendering.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/font_warmup_win.h
diff --git a/content/child/font_warmup_win.h b/content/child/font_warmup_win.h
index 3a89ef2fcc664b03d9720713694029386e2a084a..4c9c8bfb52307b34d57cd68595c5e5db4ba796ff 100644
--- a/content/child/font_warmup_win.h
+++ b/content/child/font_warmup_win.h
@@ -10,6 +10,7 @@
#include "base/files/file_path.h"
#include "base/macros.h"
#include "content/common/content_export.h"
+#include "third_party/skia/include/core/SkRefCnt.h"
jochen (gone - plz use gerrit) 2017/01/10 09:53:04 you should be able to forward declare template<typ
bungeman-chromium 2017/01/10 18:31:14 I had thought such things were frowned upon, but n
class SkFontMgr;
@@ -39,7 +40,8 @@ CONTENT_EXPORT void ResetEmulatedGdiHandlesForTesting();
// Sets the pre-sandbox warmup font manager directly. This should only be used
// for testing the implementation.
-CONTENT_EXPORT void SetPreSandboxWarmupFontMgrForTesting(SkFontMgr* fontmgr);
+CONTENT_EXPORT void SetPreSandboxWarmupFontMgrForTesting(
+ sk_sp<SkFontMgr> fontmgr);
// Directwrite connects to the font cache service to retrieve information about
// fonts installed on the system etc. This works well outside the sandbox and
« no previous file with comments | « content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc ('k') | content/child/font_warmup_win.cc » ('j') | third_party/WebKit/public/web/win/WebFontRendering.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698