Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issue 2618433002: Landing Recent QUIC changes until 12:46 PM, Dec 31, 2016 UTC-5 (Closed)

Created:
3 years, 11 months ago by rjshade
Modified:
3 years, 11 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 12:46 PM, Dec 31, 2016 UTC-5 There are no flags to be updated. Migrate StringPiece::AppendToString to StrAppend Merge internal change: 143299373 https://codereview.chromium.org/2617523002/ Add tests for QuicTextUtils::HexEncode and HexDecode which use non-ASCII printable data. Merge internal change: 143126254 https://codereview.chromium.org/2616493003/ R=rch@chromium.org BUG= Committed: https://crrev.com/9a7c0efc2c9818581fe17d1c2591687b7f8c5fe1 Cr-Commit-Position: refs/heads/master@{#441473}

Patch Set 1 #

Patch Set 2 : Migrate StringPiece::AppendToString to StrAppend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M net/quic/core/quic_framer_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/platform/api/quic_text_utils_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
rjshade
3 years, 11 months ago (2017-01-04 16:01:33 UTC) #1
Jana
lgtm Excellent week to have merge :-)
3 years, 11 months ago (2017-01-04 21:11:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618433002/20001
3 years, 11 months ago (2017-01-04 21:12:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 21:43:02 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 21:47:53 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a7c0efc2c9818581fe17d1c2591687b7f8c5fe1
Cr-Commit-Position: refs/heads/master@{#441473}

Powered by Google App Engine
This is Rietveld 408576698