Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 261843004: More changes to support incognito mode in the IDB/Blob code. (Closed)

Created:
6 years, 7 months ago by ericu
Modified:
6 years, 7 months ago
Reviewers:
jsbell, cmumford
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

More changes to support incognito mode in the IDB/Blob code. Also includes a few small cleanup changes I noticed while I was in there. BUG=108012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269605

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 4

Patch Set 3 : Rolled in Josh's feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -33 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.h View 1 2 6 chunks +28 lines, -18 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 2 8 chunks +60 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ericu
6 years, 7 months ago (2014-05-05 20:58:34 UTC) #1
jsbell
lgtm https://codereview.chromium.org/261843004/diff/20001/content/browser/indexed_db/indexed_db_backing_store.cc File content/browser/indexed_db/indexed_db_backing_store.cc (right): https://codereview.chromium.org/261843004/diff/20001/content/browser/indexed_db/indexed_db_backing_store.cc#newcode3439 content/browser/indexed_db/indexed_db_backing_store.cc:3439: BlobChangeMap& target_map = backing_store_->incognito_blob_map_; nit: move this out ...
6 years, 7 months ago (2014-05-05 22:21:23 UTC) #2
ericu
https://codereview.chromium.org/261843004/diff/20001/content/browser/indexed_db/indexed_db_backing_store.cc File content/browser/indexed_db/indexed_db_backing_store.cc (right): https://codereview.chromium.org/261843004/diff/20001/content/browser/indexed_db/indexed_db_backing_store.cc#newcode3439 content/browser/indexed_db/indexed_db_backing_store.cc:3439: BlobChangeMap& target_map = backing_store_->incognito_blob_map_; On 2014/05/05 22:21:23, jsbell wrote: ...
6 years, 7 months ago (2014-05-05 23:03:20 UTC) #3
cmumford
lgtm
6 years, 7 months ago (2014-05-09 16:30:50 UTC) #4
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 7 months ago (2014-05-09 16:33:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/261843004/40001
6 years, 7 months ago (2014-05-09 16:34:59 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 18:53:01 UTC) #7
Message was sent while issue was closed.
Change committed as 269605

Powered by Google App Engine
This is Rietveld 408576698