Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4955)

Unified Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

Issue 2618393003: Remove ScopedVector from ContentBrowserClient. (Closed)
Patch Set: chromeos Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
diff --git a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
index e5fe52bb7b805f28cb47c5cdfe4594a814f001f1..14c59420d20b8301aac4ad6f9b53a0952b0b17dc 100644
--- a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
+++ b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
@@ -11,6 +11,7 @@
#include "base/command_line.h"
#include "base/debug/alias.h"
#include "base/debug/dump_without_crashing.h"
+#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -769,16 +770,19 @@ void ChromeContentBrowserClientExtensionsPart::GetURLRequestAutoMountHandlers(
void ChromeContentBrowserClientExtensionsPart::GetAdditionalFileSystemBackends(
content::BrowserContext* browser_context,
const base::FilePath& storage_partition_path,
- ScopedVector<storage::FileSystemBackend>* additional_backends) {
+ std::vector<std::unique_ptr<storage::FileSystemBackend>>*
+ additional_backends) {
base::SequencedWorkerPool* pool = content::BrowserThread::GetBlockingPool();
- additional_backends->push_back(new MediaFileSystemBackend(
+ additional_backends->push_back(base::MakeUnique<MediaFileSystemBackend>(
storage_partition_path,
- pool->GetSequencedTaskRunner(
- pool->GetNamedSequenceToken(
- MediaFileSystemBackend::kMediaTaskRunnerName)).get()));
-
- additional_backends->push_back(new sync_file_system::SyncFileSystemBackend(
- Profile::FromBrowserContext(browser_context)));
+ pool
+ ->GetSequencedTaskRunner(pool->GetNamedSequenceToken(
Devlin 2017/01/10 22:39:26 that's weird. Did git cl format do this? Seems l
Avi (use Gerrit) 2017/01/11 18:14:01 Yep, this is clang format. We have a chain of cal
+ MediaFileSystemBackend::kMediaTaskRunnerName))
+ .get()));
+
+ additional_backends->push_back(
+ base::MakeUnique<sync_file_system::SyncFileSystemBackend>(
+ Profile::FromBrowserContext(browser_context)));
}
void ChromeContentBrowserClientExtensionsPart::

Powered by Google App Engine
This is Rietveld 408576698