Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2618383003:
Remove the extra separator appears on the right side of the shelf (Closed)
|
Created:
3 years, 11 months ago by yiyix Modified:
3 years, 11 months ago Reviewers:
James Cook CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove the extra separator appears on the right side of the shelf
TEST=MANUAL
BUG=679427
Review-Url: https://codereview.chromium.org/2618383003
Cr-Commit-Position: refs/heads/master@{#442502}
Committed: https://chromium.googlesource.com/chromium/src/+/ee16fc4f187bb47b7a2a0535c59ae9feb152a169
Patch Set 1 #
Total comments: 10
Patch Set 2 : address nits #
Total comments: 1
Patch Set 3 : update name #
Messages
Total messages: 29 (19 generated)
Description was changed from ========== fix bug BUG=679427 ========== to ========== Remove the extra separator appears on the right side of the shelf BUG=679427 ==========
yiyix@chromium.org changed reviewers: + tdanderson@chromium.org
Description was changed from ========== Remove the extra separator appears on the right side of the shelf BUG=679427 ========== to ========== Remove the extra separator appears on the right side of the shelf TEST=MANUAL BUG=679427 ==========
@tdanderson, could you please take a look?
@tdanderson, could you please take a look?
The CQ bit was checked by yiyix@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yiyix@chromium.org changed reviewers: + jamescook@chromium.org - tdanderson@chromium.org
@jamescook, Could you please take a look?
LGTM with nits https://codereview.chromium.org/2618383003/diff/1/ash/common/system/chromeos/... File ash/common/system/chromeos/session/logout_button_tray.cc (right): https://codereview.chromium.org/2618383003/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/session/logout_button_tray.cc:119: SetSeparatorVisibility(false); nit: comment why this is false (because logout button has a strong visual right edge so doesn't need it?) https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/syst... File ash/common/system/tray/system_tray.cc (right): https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/syst... ash/common/system/tray/system_tray.cc:224: SetSeparatorVisibility(false); nit: add a comment saying why this doesn't need the separator (because it's rightmost) https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/tray... File ash/common/system/tray/tray_background_view.cc (right): https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/tray... ash/common/system/tray/tray_background_view.cc:524: void TrayBackgroundView::SetSeparatorVisibility(bool is_shown) { nit: whatever you choose in the header, make sure this matches the header https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/tray... ash/common/system/tray/tray_background_view.cc:528: SchedulePaint(); Is this needed? The two places you call SetSeparatorVisibility() are in constructors, so it doesn't seem to me like you would need to schedule a paint. If you don't need this then the function could be set_separator_visible() in the header (or similar). https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/tray... File ash/common/system/tray/tray_background_view.h (right): https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/tray... ash/common/system/tray/tray_background_view.h:132: void SetSeparatorVisibility(bool is_show); super nit: we usually use |visible| or just |show|.
https://codereview.chromium.org/2618383003/diff/1/ash/common/system/chromeos/... File ash/common/system/chromeos/session/logout_button_tray.cc (right): https://codereview.chromium.org/2618383003/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/session/logout_button_tray.cc:119: SetSeparatorVisibility(false); On 2017/01/09 23:50:53, James Cook wrote: > nit: comment why this is false (because logout button has a strong visual right > edge so doesn't need it?) You are right, after removing the entire logics on whether to show a separator, some comments would help the readers to understand the new logic. https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/syst... File ash/common/system/tray/system_tray.cc (right): https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/syst... ash/common/system/tray/system_tray.cc:224: SetSeparatorVisibility(false); On 2017/01/09 23:50:53, James Cook wrote: > nit: add a comment saying why this doesn't need the separator (because it's > rightmost) similar to above, thank you. https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/tray... File ash/common/system/tray/tray_background_view.cc (right): https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/tray... ash/common/system/tray/tray_background_view.cc:524: void TrayBackgroundView::SetSeparatorVisibility(bool is_shown) { On 2017/01/09 23:50:53, James Cook wrote: > nit: whatever you choose in the header, make sure this matches the header Done. https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/tray... ash/common/system/tray/tray_background_view.cc:528: SchedulePaint(); On 2017/01/09 23:50:53, James Cook wrote: > Is this needed? The two places you call SetSeparatorVisibility() are in > constructors, so it doesn't seem to me like you would need to schedule a paint. > > If you don't need this then the function could be set_separator_visible() in the > header (or similar). I don't need SchedulePaint() now. I was thinking how separator_visible setting can be used in the future. I think i have complicated the problem. https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/tray... File ash/common/system/tray/tray_background_view.h (right): https://codereview.chromium.org/2618383003/diff/1/ash/common/system/tray/tray... ash/common/system/tray/tray_background_view.h:132: void SetSeparatorVisibility(bool is_show); On 2017/01/09 23:50:53, James Cook wrote: > super nit: we usually use |visible| or just |show|. Done.
Patchset #2 (id:20001) has been deleted
LGTM with nit Go ahead and land this after making the change. https://codereview.chromium.org/2618383003/diff/40001/ash/common/system/tray/... File ash/common/system/tray/tray_background_view.h (right): https://codereview.chromium.org/2618383003/diff/40001/ash/common/system/tray/... ash/common/system/tray/tray_background_view.h:132: void set_separator_visibility(bool visible) { nit: I gave you bad advice. :-) For inline setters we usually match the name of the member variable. So either this should be set_is_separator_visible(), or the member should be called |separator_visible_| and the setter set_separator_visible().
The CQ bit was checked by yiyix@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamescook@chromium.org Link to the patchset: https://codereview.chromium.org/2618383003/#ps60001 (title: "update name")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by yiyix@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yiyix@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484026753355910,
"parent_rev": "62b8c3d48cfc7b4e090c0d33f409559b299fd9a1", "commit_rev":
"ee16fc4f187bb47b7a2a0535c59ae9feb152a169"}
Message was sent while issue was closed.
Description was changed from ========== Remove the extra separator appears on the right side of the shelf TEST=MANUAL BUG=679427 ========== to ========== Remove the extra separator appears on the right side of the shelf TEST=MANUAL BUG=679427 Review-Url: https://codereview.chromium.org/2618383003 Cr-Commit-Position: refs/heads/master@{#442502} Committed: https://chromium.googlesource.com/chromium/src/+/ee16fc4f187bb47b7a2a0535c59a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/ee16fc4f187bb47b7a2a0535c59a... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
