Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2618373003: Remove CFX_ArrayTemplate in cfx_psrender. (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CFX_ArrayTemplate in cfx_psrender. Use unique_ptr while we're at it. Review-Url: https://codereview.chromium.org/2618373003 Committed: https://pdfium.googlesource.com/pdfium/+/6c0c48227aa024aa6e188ed7adf4d7c3d410cff9

Patch Set 1 #

Patch Set 2 : ambiguity in << #

Patch Set 3 : win again #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -43 lines) Patch
M core/fxge/win32/cfx_psrenderer.h View 2 chunks +5 lines, -2 lines 0 comments Download
M core/fxge/win32/cfx_psrenderer.cpp View 1 2 5 chunks +36 lines, -41 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
Tom Sepez
Dan, for review.
3 years, 11 months ago (2017-01-10 18:15:17 UTC) #15
dsinclair
lgtm
3 years, 11 months ago (2017-01-10 20:13:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618373003/60001
3 years, 11 months ago (2017-01-10 21:31:31 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 21:40:35 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/6c0c48227aa024aa6e188ed7adf4d7c3d410...

Powered by Google App Engine
This is Rietveld 408576698