Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2618373002: Remove PPB_ImageData_API::GetPlatformCanvas() (Closed)

Created:
3 years, 11 months ago by f(malita)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PPB_ImageData_API::GetPlatformCanvas() None of the clients requires platform-specific functionality, and since http://crrev.com/11138024 it returns a plain SkCanvas. Update call sites to GetCanvas() and remove GetPlatformCanvas(). R=reed@google.com,raymes@chromium.org,avi@chromium.org BUG=675977 Review-Url: https://codereview.chromium.org/2618373002 Cr-Commit-Position: refs/heads/master@{#442581} Committed: https://chromium.googlesource.com/chromium/src/+/05750b71186470dd0e4e2096e0209b75003b976b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -42 lines) Patch
M content/child/browser_font_resource_trusted.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.h View 4 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ppapi/thunk/ppb_image_data_api.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
f(malita)
3 years, 11 months ago (2017-01-09 16:58:00 UTC) #4
reed1
lgtm
3 years, 11 months ago (2017-01-09 18:56:53 UTC) #7
f(malita)
+owners avi@: content/ raymes@: ppapi/
3 years, 11 months ago (2017-01-09 19:10:45 UTC) #11
Avi (use Gerrit)
lgtm 👍
3 years, 11 months ago (2017-01-09 19:16:26 UTC) #12
raymes
lgtm
3 years, 11 months ago (2017-01-10 01:02:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618373002/1
3 years, 11 months ago (2017-01-10 14:34:50 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 14:38:48 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/05750b71186470dd0e4e2096e020...

Powered by Google App Engine
This is Rietveld 408576698