Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/page_sets/todomvc.py

Issue 2618333006: [tools/perf] Fix JavaScript interpolation in action_runner calls (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/perf/page_sets/google_pages.py ('K') | « tools/perf/page_sets/system_health/media_stories.py ('k') | tools/perf/page_sets/top_7_stress.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/todomvc.py
diff --git a/tools/perf/page_sets/todomvc.py b/tools/perf/page_sets/todomvc.py
index 35daccbd6fc847b23504e1983260c776852690d3..af52b51d1e373bfb76cdbf09aa8ede9f47fdef26 100644
--- a/tools/perf/page_sets/todomvc.py
+++ b/tools/perf/page_sets/todomvc.py
@@ -48,8 +48,8 @@ class TodoMVCPage(page_module.Page):
"""
)
action_runner.WaitForJavaScriptCondition('this.becameIdle === true')
- # TODO(catapult:#3028): Fix interpolation of JavaScript values.
- action_runner.ExecuteJavaScript('console.timeEnd("%s");' % INTERACTION_NAME)
+ action_runner.ExecuteJavaScript(
+ 'console.timeEnd({{ label }});', label=INTERACTION_NAME)
class TodoMVCPageSet(story.StorySet):
« tools/perf/page_sets/google_pages.py ('K') | « tools/perf/page_sets/system_health/media_stories.py ('k') | tools/perf/page_sets/top_7_stress.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698