tools/perf/page_sets/google_pages.py - Issue 2618333006: [tools/perf] Fix JavaScript interpolation in action_runner calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/google_pages.py

Issue 2618333006: [tools/perf] Fix JavaScript interpolation in action_runner calls (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/google_pages.py

diff --git a/tools/perf/page_sets/google_pages.py b/tools/perf/page_sets/google_pages.py

index d782a475f3c6b29a14d533097763682749fa18dd..4fabd4806d4d41be4dff9741bbad3dbf6b5134cb 100644

--- a/tools/perf/page_sets/google_pages.py

+++ b/tools/perf/page_sets/google_pages.py

@@ -77,5 +77,5 @@ class AdwordCampaignDesktopPage(page_module.Page):

def RunPageInteractions(self, action_runner):

action_runner.WaitForElement(text='Welcome to AdWords!')

- # TODO(catapult:#3028): Fix interpolation of JavaScript values.

- action_runner.ExecuteJavaScript('console.timeEnd("%s");' % INTERACTION_NAME)

+ action_runner.ExecuteJavaScript(

+ 'console.timeEnd({{ label }});', label=INTERACTION_NAME)