CSS Animations: fix flaky transition-and-animation-2.html

CSS Animations: fix flaky transition-and-animation-2.html

We now wait for the end event instead of using setTimeout.

BUG=248938
Review-Url: https://codereview.chromium.org/2618293002
Cr-Commit-Position: refs/heads/master@{#442839}
Committed: https://chromium.googlesource.com/chromium/src/+/7686b278333dad35c85b95eb4a7826112d64caff

[Eric Willigers, 2017-01-09 10:44:55]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 10:45:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-01-09 10:45:22]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[commit-bot: I haz the power, 2017-01-09 12:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 12:03:22]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-01-11 04:00:50]

https://codereview.chromium.org/2618293002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/animations/transition-and-animation-2.html
(right):

https://codereview.chromium.org/2618293002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/transition-and-animation-2.html:49:
box.style.transform = 'translate(400px, 0)';
What is the point of starting the transition? The point of this test is very
unclear.

[Eric Willigers, 2017-01-11 05:06:52]

https://codereview.chromium.org/2618293002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/animations/transition-and-animation-2.html
(right):

https://codereview.chromium.org/2618293002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/transition-and-animation-2.html:49:
box.style.transform = 'translate(400px, 0)';
On 2017/01/11 04:00:50, alancutter wrote:
> What is the point of starting the transition? The point of this test is very
> unclear.

We show what happens when the animation completes: we jump to 400,0 instead of
transitioning from translate(400px, 100px) to 400,0.

[alancutter (OOO until 2018), 2017-01-11 05:11:36]

lgtm after comments addressed.

https://codereview.chromium.org/2618293002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/animations/transition-and-animation-2.html
(right):

https://codereview.chromium.org/2618293002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/transition-and-animation-2.html:38:
assert_equals(getComputedStyle(box).transform, 'matrix(1, 0, 0, 1, 400, 0)');
This expectation needs some explanation. We expect no transition here right?

https://codereview.chromium.org/2618293002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/transition-and-animation-2.html:49:
box.style.transform = 'translate(400px, 0)';
On 2017/01/11 at 05:06:52, Eric Willigers wrote:
> On 2017/01/11 04:00:50, alancutter wrote:
> > What is the point of starting the transition? The point of this test is very
> > unclear.
> 
> We show what happens when the animation completes: we jump to 400,0 instead of
transitioning from translate(400px, 100px) to 400,0.

Sorry, the ordering of the code confused me. I think it's safe to put the event
handler below this function given that it occurs in the same script execution
task.

[Eric Willigers, 2017-01-11 06:28:05]

Patchset #2 (id:20001) has been deleted

[Eric Willigers, 2017-01-11 06:28:16]

https://codereview.chromium.org/2618293002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/animations/transition-and-animation-2.html
(right):

https://codereview.chromium.org/2618293002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/transition-and-animation-2.html:38:
assert_equals(getComputedStyle(box).transform, 'matrix(1, 0, 0, 1, 400, 0)');
On 2017/01/11 05:11:36, alancutter wrote:
> This expectation needs some explanation. We expect no transition here right?

Correct. Comment added.

https://codereview.chromium.org/2618293002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/transition-and-animation-2.html:49:
box.style.transform = 'translate(400px, 0)';
On 2017/01/11 05:11:36, alancutter wrote:
> On 2017/01/11 at 05:06:52, Eric Willigers wrote:
> > On 2017/01/11 04:00:50, alancutter wrote:
> > > What is the point of starting the transition? The point of this test is
very
> > > unclear.
> > 
> > We show what happens when the animation completes: we jump to 400,0 instead
of
> transitioning from translate(400px, 100px) to 400,0.
> 
> Sorry, the ordering of the code confused me. I think it's safe to put the
event
> handler below this function given that it occurs in the same script execution
> task.

Reordered.

[Eric Willigers, 2017-01-11 06:28:25]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:28:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:43:10]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2017-01-11 07:43:54]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-01-11 07:43:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2618293002/#ps40001
(title: "clarifying comments")

[commit-bot: I haz the power, 2017-01-11 07:44:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-01-11 09:26:48]

The CQ bit was unchecked by ericwilligers@chromium.org

[Eric Willigers, 2017-01-11 09:26:56]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-01-11 09:27:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:11:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484126816385470,
"parent_rev": "5df504c980216b3f756114bd83b77cfdd0be3104", "commit_rev":
"7686b278333dad35c85b95eb4a7826112d64caff"}

[commit-bot: I haz the power, 2017-01-11 10:11:34]

Description was changed from

==========
CSS Animations: fix flaky transition-and-animation-2.html

We now wait for the end event instead of using setTimeout.

BUG=248938
==========

to

==========
CSS Animations: fix flaky transition-and-animation-2.html

We now wait for the end event instead of using setTimeout.

BUG=248938

Review-Url: https://codereview.chromium.org/2618293002
Cr-Commit-Position: refs/heads/master@{#442839}
Committed:
https://chromium.googlesource.com/chromium/src/+/7686b278333dad35c85b95eb4a78...
==========

[commit-bot: I haz the power, 2017-01-11 10:11:35]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7686b278333dad35c85b95eb4a78...