Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2618273002: [turbofan] A bug fix of loadElimination (Closed)

Created:
3 years, 11 months ago by Pan
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] A bug fix of loadElimination. KillFields of an object should remove its cache from all the fields. Currently, the cache in the front field is kept which is not expected. This patch fixes it. Review-Url: https://codereview.chromium.org/2618273002 Cr-Commit-Position: refs/heads/master@{#42388} Committed: https://chromium.googlesource.com/v8/v8/+/3df428bb927679eb4bde0247f05d4b52848ee92f

Patch Set 1 #

Patch Set 2 : add test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M src/compiler/load-elimination.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/load-elimination-unittest.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Pan
@bmeurer, PTAL this should be that?
3 years, 11 months ago (2017-01-09 09:15:42 UTC) #6
Benedikt Meurer
Can you add a regression test and add a description of the bug?
3 years, 11 months ago (2017-01-09 09:55:49 UTC) #7
Benedikt Meurer
LGTM, thanks.
3 years, 11 months ago (2017-01-16 11:26:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618273002/20001
3 years, 11 months ago (2017-01-17 02:44:01 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 03:12:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/3df428bb927679eb4bde0247f05d4b52848...

Powered by Google App Engine
This is Rietveld 408576698