Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2618113002: Fixes resizing windows outside their bounds with ash-mus (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes resizing windows outside their bounds with ash-mus The resize handlers are now necessary as aura-mus dispatches events using the same path as aura non-mus. Without this change the MoveEventHandler installed on the window in the mash side doesn't get events and resize fails. BUG=none TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2618113002 Cr-Commit-Position: refs/heads/master@{#442097} Committed: https://chromium.googlesource.com/chromium/src/+/dad848c2408d0fc99ab2d4c1ada2e336f88c7b3c

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M ash/aura/wm_window_aura.cc View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
I'm hoping test coverage comes once we start using more of the ash tests for ...
3 years, 11 months ago (2017-01-06 22:52:40 UTC) #1
msw
lgtm
3 years, 11 months ago (2017-01-06 23:04:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618113002/20001
3 years, 11 months ago (2017-01-06 23:11:55 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 23:45:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dad848c2408d0fc99ab2d4c1ada2...

Powered by Google App Engine
This is Rietveld 408576698