Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2618083002: Disable Quarantine tests on platforms its not supported. (Closed)

Created:
3 years, 11 months ago by mbjorge
Modified:
3 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Disable Quarantine tests on chromecast. BUG=678341 Review-Url: https://codereview.chromium.org/2618083002 Cr-Commit-Position: refs/heads/master@{#442089} Committed: https://chromium.googlesource.com/chromium/src/+/6cfa618ab0a05e919b4f375409e9f27e76d21a87

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use GN flag to just not build tests instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/test/BUILD.gn View 1 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 20 (6 generated)
mbjorge
3 years, 11 months ago (2017-01-06 20:38:12 UTC) #2
mbjorge
3 years, 11 months ago (2017-01-06 20:38:36 UTC) #4
bcf
https://codereview.chromium.org/2618083002/diff/1/content/common/quarantine/quarantine_linux.cc File content/common/quarantine/quarantine_linux.cc (right): https://codereview.chromium.org/2618083002/diff/1/content/common/quarantine/quarantine_linux.cc#newcode101 content/common/quarantine/quarantine_linux.cc:101: bool IsQuarantineSupportedForTesting() { We should update quarantine_linux_unittest.cc to use ...
3 years, 11 months ago (2017-01-06 20:43:00 UTC) #5
Avi (use Gerrit)
Question: I just realized that the platform we're talking about is Chromecast. Do you already ...
3 years, 11 months ago (2017-01-06 20:47:36 UTC) #6
mbjorge
On 2017/01/06 at 20:47:36, avi wrote: > Question: I just realized that the platform we're ...
3 years, 11 months ago (2017-01-06 22:00:31 UTC) #7
mbjorge
On 2017/01/06 at 22:00:31, mbjorge wrote: > On 2017/01/06 at 20:47:36, avi wrote: > > ...
3 years, 11 months ago (2017-01-06 22:00:43 UTC) #8
mbjorge
3 years, 11 months ago (2017-01-06 22:00:54 UTC) #9
Avi (use Gerrit)
I think this is a better solution. LGTM
3 years, 11 months ago (2017-01-06 22:02:51 UTC) #10
bcf
lgtm
3 years, 11 months ago (2017-01-06 22:04:07 UTC) #11
bcf
Maybe change commit message to [Chromecast] ?
3 years, 11 months ago (2017-01-06 22:04:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618083002/20001
3 years, 11 months ago (2017-01-06 22:06:30 UTC) #15
mbjorge
On 2017/01/06 at 22:04:50, bcf wrote: > Maybe change commit message to [Chromecast] ? Done
3 years, 11 months ago (2017-01-06 22:27:51 UTC) #16
asanka
lgtm
3 years, 11 months ago (2017-01-06 22:33:52 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 23:15:05 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6cfa618ab0a05e919b4f375409e9...

Powered by Google App Engine
This is Rietveld 408576698