|
|
Description[Chromecast] Disable Quarantine tests on chromecast.
BUG=678341
Review-Url: https://codereview.chromium.org/2618083002
Cr-Commit-Position: refs/heads/master@{#442089}
Committed: https://chromium.googlesource.com/chromium/src/+/6cfa618ab0a05e919b4f375409e9f27e76d21a87
Patch Set 1 #
Total comments: 1
Patch Set 2 : Use GN flag to just not build tests instead #Messages
Total messages: 20 (6 generated)
mbjorge@chromium.org changed reviewers: + asanka@chromium.org, avi@chromium.org, jochen@chromium.org
mbjorge@chromium.org changed reviewers: + bcf@chromium.org
https://codereview.chromium.org/2618083002/diff/1/content/common/quarantine/q... File content/common/quarantine/quarantine_linux.cc (right): https://codereview.chromium.org/2618083002/diff/1/content/common/quarantine/q... content/common/quarantine/quarantine_linux.cc:101: bool IsQuarantineSupportedForTesting() { We should update quarantine_linux_unittest.cc to use this new function in QuarantineLinuxTest::SetUp
Question: I just realized that the platform we're talking about is Chromecast. Do you already have a build flag? Can we edit the .gn file to make these tests not build for that target platform?
On 2017/01/06 at 20:47:36, avi wrote: > Question: I just realized that the platform we're talking about is Chromecast. Do you already have a build flag? Can we edit the .gn file to make these tests not build for that target platform? Yes, there is a is_chromecast build flag
On 2017/01/06 at 22:00:31, mbjorge wrote: > On 2017/01/06 at 20:47:36, avi wrote: > > Question: I just realized that the platform we're talking about is Chromecast. Do you already have a build flag? Can we edit the .gn file to make these tests not build for that target platform? > > Yes, there is a is_chromecast build flag. Updated CL.
I think this is a better solution. LGTM
lgtm
Maybe change commit message to [Chromecast] ?
Description was changed from ========== Disable Quarantine tests on platforms its not supported. BUG=678341 ========== to ========== [Chromecast] Disable Quarantine tests on chromecast. BUG=678341 ==========
The CQ bit was checked by mbjorge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/06 at 22:04:50, bcf wrote: > Maybe change commit message to [Chromecast] ? Done
lgtm
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483740358237890, "parent_rev": "149963d671825cc359fa59c489880036cd114f8e", "commit_rev": "6cfa618ab0a05e919b4f375409e9f27e76d21a87"}
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] Disable Quarantine tests on chromecast. BUG=678341 ========== to ========== [Chromecast] Disable Quarantine tests on chromecast. BUG=678341 Review-Url: https://codereview.chromium.org/2618083002 Cr-Commit-Position: refs/heads/master@{#442089} Committed: https://chromium.googlesource.com/chromium/src/+/6cfa618ab0a05e919b4f375409e9... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6cfa618ab0a05e919b4f375409e9... |