Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2618063002: Send Mouse Leave events all the time when we get a ET_MOUSE_EXITED (Closed)

Created:
3 years, 11 months ago by dtapuska
Modified:
3 years, 11 months ago
Reviewers:
tdresser, Rick Byers
CC:
chromium-reviews, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send Mouse Leave events all the time when we get a ET_MOUSE_EXITED Once we have shipped this for a release this feature flag can be removed. I've tested Windows and the issues causing the spurious ET_MOUSE_EXITED don't exist anymore so I believe this is safe to ship in this fashion. BUG=450631, 240300, 352106, 386896, 569998, 575208 Review-Url: https://codereview.chromium.org/2618063002 Cr-Commit-Position: refs/heads/master@{#442076} Committed: https://chromium.googlesource.com/chromium/src/+/3963e231e4c43187a05f3c6420f5df997d734ea0

Patch Set 1 #

Patch Set 2 : Fix test failure on linux #

Total comments: 2

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M content/browser/renderer_host/render_widget_host_view_event_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/blink_features.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/blink/blink_features.cc View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
dtapuska
3 years, 11 months ago (2017-01-06 18:43:56 UTC) #4
Rick Byers
sweet, hope it works out well. LGTM
3 years, 11 months ago (2017-01-06 18:58:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618063002/1
3 years, 11 months ago (2017-01-06 20:21:32 UTC) #10
dtapuska
Tim, can you look at this I had to modify the check on linux as ...
3 years, 11 months ago (2017-01-06 20:55:42 UTC) #12
tdresser
Nit: suprious -> spurious in the CL description. LGTM https://codereview.chromium.org/2618063002/diff/20001/ui/events/blink/blink_features.h File ui/events/blink/blink_features.h (right): https://codereview.chromium.org/2618063002/diff/20001/ui/events/blink/blink_features.h#newcode16 ui/events/blink/blink_features.h:16: ...
3 years, 11 months ago (2017-01-06 21:39:15 UTC) #13
dtapuska
https://codereview.chromium.org/2618063002/diff/20001/ui/events/blink/blink_features.h File ui/events/blink/blink_features.h (right): https://codereview.chromium.org/2618063002/diff/20001/ui/events/blink/blink_features.h#newcode16 ui/events/blink/blink_features.h:16: // converted to mouse move events due to a ...
3 years, 11 months ago (2017-01-06 21:47:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618063002/40001
3 years, 11 months ago (2017-01-06 21:47:55 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 22:39:23 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3963e231e4c43187a05f3c6420f5...

Powered by Google App Engine
This is Rietveld 408576698