Fix displayed duration after onDurationChange

Fix displayed duration after onDurationChange

MediaControls::onDurationChange updates m_timeline, but does not update
the displayed duration. This means that HLS streams (and propably other
types of media) always have a duration of '0:00', because we don't know
the duration until we have started playing the media (and we initially
report a 0s duration).

This change fixes onDurationChange.

BUG=679049
TEST= Manually confirmed using a test HLS stream

Review-Url: https://codereview.chromium.org/2617993003
Cr-Commit-Position: refs/heads/master@{#442330}
Committed: https://chromium.googlesource.com/chromium/src/+/5e9a62259f89620d6c31829937af7dd59b486f10

[tguilbert, 2017-01-06 23:21:15]

tguilbert@chromium.org changed reviewers:
+ mlamouri@chromium.org

[tguilbert, 2017-01-06 23:21:16]

PTAL :)

Thank you,
Thomas

[tguilbert, 2017-01-06 23:21:25]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 23:21:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 01:05:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 01:05:10]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-01-09 13:41:00]

lgtm -- though, would you mind keeping the current time and duration text update
together and the timeline after. Basically, having them separated by an empty
line to make it clearer these are different things. It's weird enough as it is
:)

[tguilbert, 2017-01-09 18:51:45]

On 2017/01/09 13:41:00, mlamouri wrote:
> lgtm -- though, would you mind keeping the current time and duration text
update
> together and the timeline after. Basically, having them separated by an empty
> line to make it clearer these are different things. It's weird enough as it is
> :)

Done :)

[tguilbert, 2017-01-09 18:51:49]

The CQ bit was checked by tguilbert@chromium.org

[tguilbert, 2017-01-09 18:51:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2617993003/#ps20001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-01-09 18:52:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sarsilmazismet_gmail.com, 2017-01-09 18:53:37]

S88aaui

9 Oca 2017 20:51 tarihinde <tguilbert@chromium.org> yazdı:

> On 2017/01/09 13:41:00, mlamouri wrote:
> > lgtm -- though, would you mind keeping the current time and duration text
> update
> > together and the timeline after. Basically, having them separated by an
> empty
> > line to make it clearer these are different things. It's weird enough as
> it is
> > :)
>
> Done :)
>
> https://codereview.chromium.org/2617993003/
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink reviews html" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-reviews-html+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[sarsilmazismet_gmail.com, 2017-01-09 18:53:37]

S88aaui

9 Oca 2017 20:51 tarihinde <tguilbert@chromium.org> yazdı:

> On 2017/01/09 13:41:00, mlamouri wrote:
> > lgtm -- though, would you mind keeping the current time and duration text
> update
> > together and the timeline after. Basically, having them separated by an
> empty
> > line to make it clearer these are different things. It's weird enough as
> it is
> > :)
>
> Done :)
>
> https://codereview.chromium.org/2617993003/
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink reviews html" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-reviews-html+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-01-09 20:38:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483987909028180,
"parent_rev": "aef5c1f5d4a23b24300e2bc3e2099c14e48ce21e", "commit_rev":
"5e9a62259f89620d6c31829937af7dd59b486f10"}

[commit-bot: I haz the power, 2017-01-09 20:39:03]

Description was changed from

==========
Fix displayed duration after onDurationChange

MediaControls::onDurationChange updates m_timeline, but does not update
the displayed duration. This means that HLS streams (and propably other
types of media) always have a duration of '0:00', because we don't know
the duration until we have started playing the media (and we initially
report a 0s duration).

This change fixes onDurationChange.

BUG=679049
TEST= Manually confirmed using a test HLS stream
==========

to

==========
Fix displayed duration after onDurationChange

MediaControls::onDurationChange updates m_timeline, but does not update
the displayed duration. This means that HLS streams (and propably other
types of media) always have a duration of '0:00', because we don't know
the duration until we have started playing the media (and we initially
report a 0s duration).

This change fixes onDurationChange.

BUG=679049
TEST= Manually confirmed using a test HLS stream

Review-Url: https://codereview.chromium.org/2617993003
Cr-Commit-Position: refs/heads/master@{#442330}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e9a62259f89620d6c31829937af...
==========

[commit-bot: I haz the power, 2017-01-09 20:39:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5e9a62259f89620d6c31829937af...