Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 2617973002: Print <<NULL>> instead of crashing. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Change <<NULL>> to <Null>. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/kernel/lib/text/ast_to_text.dart View 1 1 chunk +5 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
ahe
https://codereview.chromium.org/2617973002/diff/1/pkg/kernel/lib/text/ast_to_text.dart File pkg/kernel/lib/text/ast_to_text.dart (right): https://codereview.chromium.org/2617973002/diff/1/pkg/kernel/lib/text/ast_to_text.dart#newcode397 pkg/kernel/lib/text/ast_to_text.dart:397: writeSymbol("<<NULL>>"); Any suggestions for a better string to use ...
3 years, 11 months ago (2017-01-06 15:32:31 UTC) #3
asgerf
lgtm https://codereview.chromium.org/2617973002/diff/1/pkg/kernel/lib/text/ast_to_text.dart File pkg/kernel/lib/text/ast_to_text.dart (right): https://codereview.chromium.org/2617973002/diff/1/pkg/kernel/lib/text/ast_to_text.dart#newcode397 pkg/kernel/lib/text/ast_to_text.dart:397: writeSymbol("<<NULL>>"); On 2017/01/06 15:32:31, ahe wrote: > Any ...
3 years, 11 months ago (2017-01-06 15:33:36 UTC) #4
ahe
Great idea, thank you! https://codereview.chromium.org/2617973002/diff/1/pkg/kernel/lib/text/ast_to_text.dart File pkg/kernel/lib/text/ast_to_text.dart (right): https://codereview.chromium.org/2617973002/diff/1/pkg/kernel/lib/text/ast_to_text.dart#newcode397 pkg/kernel/lib/text/ast_to_text.dart:397: writeSymbol("<<NULL>>"); On 2017/01/06 15:33:36, asgerf ...
3 years, 11 months ago (2017-01-06 15:37:44 UTC) #6
ahe
3 years, 11 months ago (2017-01-11 11:35:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ae90e640eaf8042d84bb7357a2e03107588c101f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698