Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2614143003: Restore verifier flags after failed verification. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/fe_integration
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M pkg/kernel/lib/verifier.dart View 1 4 chunks +29 lines, -14 lines 0 comments Download

Depends on Patchset:

Issue 2617973002 Patch 20001

Messages

Total messages: 7 (3 generated)
ahe
3 years, 11 months ago (2017-01-06 15:51:53 UTC) #3
asgerf
lgtm https://codereview.chromium.org/2614143003/diff/20001/pkg/kernel/lib/verifier.dart File pkg/kernel/lib/verifier.dart (right): https://codereview.chromium.org/2614143003/diff/20001/pkg/kernel/lib/verifier.dart#newcode21 pkg/kernel/lib/verifier.dart:21: bool isOutline = false; Please add a short ...
3 years, 11 months ago (2017-01-06 15:56:26 UTC) #4
ahe
Thank you, Asger! https://codereview.chromium.org/2614143003/diff/20001/pkg/kernel/lib/verifier.dart File pkg/kernel/lib/verifier.dart (right): https://codereview.chromium.org/2614143003/diff/20001/pkg/kernel/lib/verifier.dart#newcode21 pkg/kernel/lib/verifier.dart:21: bool isOutline = false; On 2017/01/06 ...
3 years, 11 months ago (2017-01-11 11:39:29 UTC) #5
ahe
3 years, 11 months ago (2017-01-11 11:39:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
e7ac20e4f5afd37ecea2ae34d049e42549d74ce9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698