Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 2617943002: [MD Bookmarks] Edit Bookmarks. (Closed)

Created:
3 years, 11 months ago by jiaxi
Modified:
3 years, 11 months ago
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Edit Bookmarks. This CL enables edit function for bookmarks. When the edit button in the dropdown menu for bookmarks is tapped, it will open an edit dialog. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2617943002 Cr-Commit-Position: refs/heads/master@{#442470} Committed: https://chromium.googlesource.com/chromium/src/+/f0fbe3213ad51e6d6404c10f6de9cc9461cff1fa

Patch Set 1 #

Total comments: 3

Patch Set 2 : style fix #

Total comments: 5

Patch Set 3 : merge #

Patch Set 4 : safe guard #

Total comments: 3

Patch Set 5 : merge #

Patch Set 6 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -45 lines) Patch
M chrome/browser/resources/md_bookmarks/list.html View 1 2 3 4 2 chunks +29 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.js View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/shared_style.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/shared_vars.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/store.js View 1 2 4 chunks +66 lines, -40 lines 0 comments Download
M chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/store_test.js View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
M components/bookmark_component_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (17 generated)
jiaxi
https://codereview.chromium.org/2617943002/diff/1/chrome/browser/resources/md_bookmarks/list.html File chrome/browser/resources/md_bookmarks/list.html (right): https://codereview.chromium.org/2617943002/diff/1/chrome/browser/resources/md_bookmarks/list.html#newcode18 chrome/browser/resources/md_bookmarks/list.html:18: According to Tim's comment: `the cr-dialog and action-button styles ...
3 years, 11 months ago (2017-01-06 06:03:53 UTC) #4
tsergeant
Cool! I like how easily the store part of this works. https://codereview.chromium.org/2617943002/diff/1/chrome/browser/resources/md_bookmarks/list.html File chrome/browser/resources/md_bookmarks/list.html (right): ...
3 years, 11 months ago (2017-01-09 00:21:05 UTC) #5
jiaxi
https://codereview.chromium.org/2617943002/diff/20001/chrome/browser/resources/md_bookmarks/list.js File chrome/browser/resources/md_bookmarks/list.js (right): https://codereview.chromium.org/2617943002/diff/20001/chrome/browser/resources/md_bookmarks/list.js#newcode33 chrome/browser/resources/md_bookmarks/list.js:33: onEditTap_: function() { On 2017/01/09 00:21:04, tsergeant wrote: > ...
3 years, 11 months ago (2017-01-09 02:17:46 UTC) #7
calamity
Looks great! #nittinfromnippon https://codereview.chromium.org/2617943002/diff/80001/chrome/browser/resources/md_bookmarks/list.html File chrome/browser/resources/md_bookmarks/list.html (right): https://codereview.chromium.org/2617943002/diff/80001/chrome/browser/resources/md_bookmarks/list.html#newcode19 chrome/browser/resources/md_bookmarks/list.html:19: #bookmarksCard { Why did this change?
3 years, 11 months ago (2017-01-09 03:19:11 UTC) #8
jiaxi
https://codereview.chromium.org/2617943002/diff/80001/chrome/browser/resources/md_bookmarks/list.html File chrome/browser/resources/md_bookmarks/list.html (right): https://codereview.chromium.org/2617943002/diff/80001/chrome/browser/resources/md_bookmarks/list.html#newcode19 chrome/browser/resources/md_bookmarks/list.html:19: #bookmarksCard { On 2017/01/09 03:19:11, calamity wrote: > Why ...
3 years, 11 months ago (2017-01-09 03:23:13 UTC) #9
tsergeant
https://codereview.chromium.org/2617943002/diff/80001/chrome/browser/resources/md_bookmarks/list.html File chrome/browser/resources/md_bookmarks/list.html (right): https://codereview.chromium.org/2617943002/diff/80001/chrome/browser/resources/md_bookmarks/list.html#newcode19 chrome/browser/resources/md_bookmarks/list.html:19: #bookmarksCard { On 2017/01/09 03:23:13, jiaxi wrote: > On ...
3 years, 11 months ago (2017-01-09 03:27:33 UTC) #10
tsergeant
lgtm
3 years, 11 months ago (2017-01-09 03:29:15 UTC) #11
jiaxi
+ blundell@chromium.org for the small string change in components/bookmark_component_strings.grdp
3 years, 11 months ago (2017-01-09 05:59:42 UTC) #15
blundell
lgtm
3 years, 11 months ago (2017-01-09 12:32:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617943002/100001
3 years, 11 months ago (2017-01-09 23:03:59 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/343158)
3 years, 11 months ago (2017-01-10 00:24:28 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617943002/120001
3 years, 11 months ago (2017-01-10 00:40:41 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 11 months ago (2017-01-10 02:43:43 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617943002/120001
3 years, 11 months ago (2017-01-10 02:55:57 UTC) #28
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 04:38:20 UTC) #31
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/f0fbe3213ad51e6d6404c10f6de9...

Powered by Google App Engine
This is Rietveld 408576698