|
|
DescriptionExpose CachedAccessorCallback in generated code
Makes these callbacks visible from other .cpp files.
BUG=617892
Review-Url: https://codereview.chromium.org/2617933002
Cr-Commit-Position: refs/heads/master@{#441888}
Committed: https://chromium.googlesource.com/chromium/src/+/1c0d372b93e0271311c106b02e140b551530d47b
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== Expose CachedAccessorCallback BUG=None ========== to ========== Expose CachedAccessorCallback in generated code Makes these callbacks visible from other .cpp files. BUG=None ==========
peria@chromium.org changed reviewers: + bashi@chromium.org, haraken@chromium.org, yukishiino@chromium.org
PTL
The CQ bit was checked by peria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by peria@chromium.org
The CQ bit was checked by peria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm, but could you elaborate why do you want to expose it? If this is needed for implementing something, adding an appropriate BUG= would be great :)
The CQ bit was unchecked by peria@chromium.org
Description was changed from ========== Expose CachedAccessorCallback in generated code Makes these callbacks visible from other .cpp files. BUG=None ========== to ========== Expose CachedAccessorCallback in generated code Makes these callbacks visible from other .cpp files. BUG=617892 ==========
On 2017/01/06 05:17:08, bashi wrote: > lgtm, but could you elaborate why do you want to expose it? If this is needed > for implementing something, adding an appropriate BUG= would be great :) Done. Yes, I need to put a cached accessor callback pointer in the external reference list for the snapshotting project. I update BUG= to figure it.
The CQ bit was checked by peria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1483680054351770, "parent_rev": "82a51d454bb51140c5c32b14d30361bbf5069d2d", "commit_rev": "1c0d372b93e0271311c106b02e140b551530d47b"}
Message was sent while issue was closed.
Description was changed from ========== Expose CachedAccessorCallback in generated code Makes these callbacks visible from other .cpp files. BUG=617892 ========== to ========== Expose CachedAccessorCallback in generated code Makes these callbacks visible from other .cpp files. BUG=617892 Review-Url: https://codereview.chromium.org/2617933002 Cr-Commit-Position: refs/heads/master@{#441888} Committed: https://chromium.googlesource.com/chromium/src/+/1c0d372b93e0271311c106b02e14... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1c0d372b93e0271311c106b02e14... |