Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2617933002: [Bindings] Expose CachedAccessorCallback (Closed)

Created:
3 years, 11 months ago by peria
Modified:
3 years, 11 months ago
Reviewers:
haraken, Yuki, bashi
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose CachedAccessorCallback in generated code Makes these callbacks visible from other .cpp files. BUG=617892 Review-Url: https://codereview.chromium.org/2617933002 Cr-Commit-Position: refs/heads/master@{#441888} Committed: https://chromium.googlesource.com/chromium/src/+/1c0d372b93e0271311c106b02e140b551530d47b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
peria
PTL
3 years, 11 months ago (2017-01-06 05:00:18 UTC) #3
haraken
LGTM
3 years, 11 months ago (2017-01-06 05:08:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617933002/1
3 years, 11 months ago (2017-01-06 05:08:50 UTC) #9
bashi
lgtm, but could you elaborate why do you want to expose it? If this is ...
3 years, 11 months ago (2017-01-06 05:17:08 UTC) #10
peria
On 2017/01/06 05:17:08, bashi wrote: > lgtm, but could you elaborate why do you want ...
3 years, 11 months ago (2017-01-06 05:20:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617933002/1
3 years, 11 months ago (2017-01-06 05:21:09 UTC) #15
Yuki
lgtm
3 years, 11 months ago (2017-01-06 05:56:45 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 06:21:31 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c0d372b93e0271311c106b02e14...

Powered by Google App Engine
This is Rietveld 408576698