Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2617923004: Makes mash use ChromeNativeAppWindowViewsAura (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes mash use ChromeNativeAppWindowViewsAura Mash should really use ChromeNativeAppWindowViewsAuraAsh, but that depends upon a bunch of types in ash. So, make mash use ChromeNativeAppWindowViewsAura, which isn't perfect, but at least it doesn't crash. BUG=679028 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2617923004 Cr-Commit-Position: refs/heads/master@{#442067} Committed: https://chromium.googlesource.com/chromium/src/+/148ae8075bfdc22e122b3307d3344337db12d00c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
3 years, 11 months ago (2017-01-06 21:20:02 UTC) #1
msw
lgtm
3 years, 11 months ago (2017-01-06 21:23:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617923004/1
3 years, 11 months ago (2017-01-06 21:27:36 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 21:54:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/148ae8075bfdc22e122b3307d334...

Powered by Google App Engine
This is Rietveld 408576698