Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2617903005: Remove dsQueryBatch in favor of ds.Batcher. (Closed)

Created:
3 years, 11 months ago by dnj
Modified:
3 years, 11 months ago
Reviewers:
Vadim Sh., iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Remove dsQueryBatch in favor of ds.Batcher. NOTRY=true NOPRESUBMIT=true BUG=chromium:679064 TEST=unit Review-Url: https://codereview.chromium.org/2617903005 Committed: https://github.com/luci/luci-go/commit/fb0dd9bf7c939a60b4199989f565c0345c3c58bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M appengine/datastorecache/cache.go View 2 chunks +2 lines, -1 line 0 comments Download
M appengine/datastorecache/manager.go View 3 chunks +5 lines, -8 lines 0 comments Download
M appengine/tsmon/handler.go View 4 chunks +6 lines, -5 lines 0 comments Download
M appengine/tsmon/handler_test.go View 1 chunk +1 line, -1 line 0 comments Download
M dm/appengine/deps/walk_graph.go View 6 chunks +10 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
dnj
PTAL
3 years, 11 months ago (2017-01-07 01:33:40 UTC) #2
Vadim Sh.
lgtm
3 years, 11 months ago (2017-01-07 01:37:38 UTC) #3
dnj
Pushing through w/out try/presubmit b/c 3-sided. Works locally.
3 years, 11 months ago (2017-01-07 01:55:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617903005/1
3 years, 11 months ago (2017-01-07 01:55:53 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 01:56:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/fb0dd9bf7c939a60b4199989f565c0345c3c58bb

Powered by Google App Engine
This is Rietveld 408576698