Convert recursion to iteration in clearClipRectsIncludingDescendants

Convert recursion to iteration in clearClipRectsIncludingDescendants

BUG=674795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617903002
Cr-Commit-Position: refs/heads/master@{#442063}
Committed: https://chromium.googlesource.com/chromium/src/+/b144a2a584a2b444b8d69405b6060911ec2b1b6f

[chrishtr, 2017-01-06 00:28:28]

Description was changed from

==========
none


none


none


none

BUG=
==========

to

==========
none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-06 00:29:20]

Description was changed from

==========
none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Covert recursion to iteration in clearClipRectsIncludingDescendants

BUG=674795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-06 00:29:33]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-01-06 00:30:14]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-01-06 00:30:56]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 00:31:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-01-06 00:43:54]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[wkorman, 2017-01-06 02:43:50]

Description was changed from

==========
Covert recursion to iteration in clearClipRectsIncludingDescendants

BUG=674795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Convert recursion to iteration in clearClipRectsIncludingDescendants

BUG=674795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2017-01-06 02:51:50]

https://codereview.chromium.org/2617903002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/2617903002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:180: void
PaintLayerClipper::clearCache(ClipRectsCacheSlot cacheSlot) {
Current unit tests in PaintLayerClipperTest look fairly limited, worth adding
some test cases to make sure this is still doing the right thing, and that the
various slots are cleared out when we expect? This Clipper business is
surprisingly complicated. I figure our layout test coverage means the core logic
will be tested as is, but it seems possible we could pass those despite some
caching missteps.

[commit-bot: I haz the power, 2017-01-06 03:07:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:07:15]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-01-06 17:20:53]

On 2017/01/06 at 02:51:50, wkorman wrote:
>
https://codereview.chromium.org/2617903002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):
> 
>
https://codereview.chromium.org/2617903002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:180: void
PaintLayerClipper::clearCache(ClipRectsCacheSlot cacheSlot) {
> Current unit tests in PaintLayerClipperTest look fairly limited, worth adding
some test cases to make sure this is still doing the right thing, and that the
various slots are cleared out when we expect? This Clipper business is
surprisingly complicated. I figure our layout test coverage means the core logic
will be tested as is, but it seems possible we could pass those despite some
caching missteps.

Done.

[chrishtr, 2017-01-06 17:20:59]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 17:21:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2017-01-06 17:30:59]

lgtm

[chrishtr, 2017-01-06 19:07:11]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-01-06 19:07:12]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-01-06 19:07:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:45:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483729632803330,
"parent_rev": "1cec8405fc3e76fb62641082f60787f4af6daad6", "commit_rev":
"b144a2a584a2b444b8d69405b6060911ec2b1b6f"}

[commit-bot: I haz the power, 2017-01-06 21:46:07]

Description was changed from

==========
Convert recursion to iteration in clearClipRectsIncludingDescendants

BUG=674795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Convert recursion to iteration in clearClipRectsIncludingDescendants

BUG=674795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617903002
Cr-Commit-Position: refs/heads/master@{#442063}
Committed:
https://chromium.googlesource.com/chromium/src/+/b144a2a584a2b444b8d69405b606...
==========

[commit-bot: I haz the power, 2017-01-06 21:46:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b144a2a584a2b444b8d69405b606...