Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2617893002: Remove uses of UseSubframeNavigationEntries in unit tests. (Closed)

Created:
3 years, 11 months ago by Charlie Reis
Modified:
3 years, 11 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uses of UseSubframeNavigationEntries in unit tests. This mode is always enabled now, so we can remove the code for handling when it is disabled. BUG=236848 TEST=Tests still pass CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2617893002 Cr-Commit-Position: refs/heads/master@{#442012} Committed: https://chromium.googlesource.com/chromium/src/+/1c3ab7394d18ee73b78e7f5458262043ea271076

Patch Set 1 #

Patch Set 2 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -99 lines) Patch
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 11 chunks +40 lines, -92 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Charlie Reis
Here's the cleanup for unit tests.
3 years, 11 months ago (2017-01-06 18:39:19 UTC) #7
nasko
LGTM
3 years, 11 months ago (2017-01-06 19:24:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617893002/20001
3 years, 11 months ago (2017-01-06 19:37:25 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 19:45:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1c3ab7394d18ee73b78e7f545826...

Powered by Google App Engine
This is Rietveld 408576698