Add a new BindInterface() method to Connector.

Add a new BindInterface() method to Connector.

This replaces ConnectToInterface, and includes an implementation in the ServiceManager (unlike ConnectToInterface which was just a call to Connect() + GetInterface). This is a step towards shifting manifest policy intersection into the ServiceManager.

R=rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2617883002
Cr-Commit-Position: refs/heads/master@{#442158}
Committed: https://chromium.googlesource.com/chromium/src/+/bd3c248c513604ca0de81dd0437c3d03aa88ca0d

[Ben Goodger (Google), 2017-01-06 00:15:17]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 00:16:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 00:28:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 00:28:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ken Rockot(use gerrit already), 2017-01-06 18:27:09]

lgtm

[Ben Goodger (Google), 2017-01-06 20:52:37]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 20:53:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:02:32]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Ben Goodger (Google), 2017-01-06 21:50:59]

Description was changed from

==========
Add a new BindInterface() method to Connector.

This replaces ConnectToInterface, and includes an implementation in the
ServiceManager (unlike ConnectToInterface which was just a call to Connect() +
GetInterface). This is a step towards shifting manifest policy intersection into
the ServiceManager.

R=rockot@chromium.org
==========

to

==========
Add a new BindInterface() method to Connector.

This replaces ConnectToInterface, and includes an implementation in the
ServiceManager (unlike ConnectToInterface which was just a call to Connect() +
GetInterface). This is a step towards shifting manifest policy intersection into
the ServiceManager.

R=rockot@chromium.org,tsepez@chromium.org
==========

[Ben Goodger (Google), 2017-01-06 21:51:00]

ben@chromium.org changed reviewers:
+ tsepez@chromium.org

[Ben Goodger (Google), 2017-01-06 21:51:59]

+tom for connector.mojom. This is the new Connector method I mentioned,
BindInterface. Existing calls to ConnectToInterface are made to call thru to
this, though policy checking is still done in the client. It will be pulled into
the service manager in a subsequent change.

Also renamed Start() to be a bit more specific.

[Tom Sepez, 2017-01-06 23:00:29]

mojom itself LGTM.

[Ben Goodger (Google), 2017-01-07 02:32:40]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-01-07 02:32:41]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2617883002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-01-07 02:32:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 02:35:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 02:35:14]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Ben Goodger (Google), 2017-01-07 02:38:53]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-01-07 02:38:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2617883002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-01-07 02:39:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 02:49:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 02:49:20]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Ben Goodger (Google), 2017-01-07 03:03:49]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-01-07 03:03:50]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2617883002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2017-01-07 03:04:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 03:13:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 03:13:44]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2017-01-07 03:52:07]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-01-07 03:52:08]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2617883002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2017-01-07 03:52:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 04:06:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 04:06:17]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2017-01-07 04:07:17]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-01-07 04:07:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2617883002/#ps120001
(title: ".")

[commit-bot: I haz the power, 2017-01-07 04:07:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 05:48:26]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1483762037445460,
"parent_rev": "af431fbd04548a9b28e5ecd59d6ad707dce55711", "commit_rev":
"bd3c248c513604ca0de81dd0437c3d03aa88ca0d"}

[commit-bot: I haz the power, 2017-01-07 05:48:54]

Description was changed from

==========
Add a new BindInterface() method to Connector.

This replaces ConnectToInterface, and includes an implementation in the
ServiceManager (unlike ConnectToInterface which was just a call to Connect() +
GetInterface). This is a step towards shifting manifest policy intersection into
the ServiceManager.

R=rockot@chromium.org,tsepez@chromium.org
==========

to

==========
Add a new BindInterface() method to Connector.

This replaces ConnectToInterface, and includes an implementation in the
ServiceManager (unlike ConnectToInterface which was just a call to Connect() +
GetInterface). This is a step towards shifting manifest policy intersection into
the ServiceManager.

R=rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2617883002
Cr-Commit-Position: refs/heads/master@{#442158}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd3c248c513604ca0de81dd0437c...
==========

[commit-bot: I haz the power, 2017-01-07 05:48:56]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/bd3c248c513604ca0de81dd0437c...