Restore logic to unsubscribe from permission changes on frame change.

Restore logic to unsubscribe from permission changes on frame change.

In r441491 I neglected to notice that the lifetime of the
PermissionManager is longer than that of PermissionServiceContext. On
frame changes existing subscriptions should be cleared as they were
before that patch.

PermissionServiceImpl::AddPermissionObserver removes redundant
early return logic checking that 
browser_context->GetPermissionManager() is non null.
CreateSubscription already does that.

BUG=677774, 678664
TBR=mlamouri@chromium.org

Review-Url: https://codereview.chromium.org/2617863003
Cr-Commit-Position: refs/heads/master@{#442042}
Committed: https://chromium.googlesource.com/chromium/src/+/9c28b5c29961ba84106ab9b84821717441e106d7

[Reilly Grant (use Gerrit), 2017-01-06 01:49:33]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 01:50:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:54:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:54:44]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-01-06 16:59:27]

reillyg@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Reilly Grant (use Gerrit), 2017-01-06 16:59:27]

Please take a look.

[scheib, 2017-01-06 20:36:57]

Description was changed from

==========
Restore logic to unsubscribe from permission changes on frame change.

In r441491 I neglected to notice that the lifetime of the
PermissionManager is longer than that of PermissionServiceContext. On
frame changes existing subscriptions should be cleared as they were
before that patch.

BUG=677774,678664
==========

to

==========
Restore logic to unsubscribe from permission changes on frame change.

In r441491 I neglected to notice that the lifetime of the
PermissionManager is longer than that of PermissionServiceContext. On
frame changes existing subscriptions should be cleared as they were
before that patch.

PermissionServiceImpl::AddPermissionObserver removes redundant
early return logic checking that 
browser_context->GetPermissionManager() is non null.
CreateSubscription already does that.

BUG=677774,678664
==========

[scheib, 2017-01-06 20:37:05]

scheib@chromium.org changed reviewers:
+ scheib@chromium.org

[scheib, 2017-01-06 20:37:06]

LGTM

[Reilly Grant (use Gerrit), 2017-01-06 20:44:10]

Description was changed from

==========
Restore logic to unsubscribe from permission changes on frame change.

In r441491 I neglected to notice that the lifetime of the
PermissionManager is longer than that of PermissionServiceContext. On
frame changes existing subscriptions should be cleared as they were
before that patch.

PermissionServiceImpl::AddPermissionObserver removes redundant
early return logic checking that 
browser_context->GetPermissionManager() is non null.
CreateSubscription already does that.

BUG=677774,678664
==========

to

==========
Restore logic to unsubscribe from permission changes on frame change.

In r441491 I neglected to notice that the lifetime of the
PermissionManager is longer than that of PermissionServiceContext. On
frame changes existing subscriptions should be cleared as they were
before that patch.

PermissionServiceImpl::AddPermissionObserver removes redundant
early return logic checking that 
browser_context->GetPermissionManager() is non null.
CreateSubscription already does that.

BUG=677774,678664
TBR=mlamouri@chromium.org
==========

[Reilly Grant (use Gerrit), 2017-01-06 20:45:01]

Thank you Vince. TBRing mlamouri because this is causing an high CPM in canary.

[Reilly Grant (use Gerrit), 2017-01-06 20:45:13]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-01-06 20:45:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:51:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483735513492220, "parent_rev":
"8f24bf65e84a4e10d260c95a250f9799c8d6127d", "commit_rev":
"9c28b5c29961ba84106ab9b84821717441e106d7"}

[commit-bot: I haz the power, 2017-01-06 20:52:02]

Description was changed from

==========
Restore logic to unsubscribe from permission changes on frame change.

In r441491 I neglected to notice that the lifetime of the
PermissionManager is longer than that of PermissionServiceContext. On
frame changes existing subscriptions should be cleared as they were
before that patch.

PermissionServiceImpl::AddPermissionObserver removes redundant
early return logic checking that 
browser_context->GetPermissionManager() is non null.
CreateSubscription already does that.

BUG=677774,678664
TBR=mlamouri@chromium.org
==========

to

==========
Restore logic to unsubscribe from permission changes on frame change.

In r441491 I neglected to notice that the lifetime of the
PermissionManager is longer than that of PermissionServiceContext. On
frame changes existing subscriptions should be cleared as they were
before that patch.

PermissionServiceImpl::AddPermissionObserver removes redundant
early return logic checking that 
browser_context->GetPermissionManager() is non null.
CreateSubscription already does that.

BUG=677774,678664
TBR=mlamouri@chromium.org

Review-Url: https://codereview.chromium.org/2617863003
Cr-Commit-Position: refs/heads/master@{#442042}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c28b5c29961ba84106ab9b84821...
==========

[commit-bot: I haz the power, 2017-01-06 20:52:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c28b5c29961ba84106ab9b84821...