Remove AssertWaitAllowed from IsParentalControlActivityLoggingOn().

Remove AssertWaitAllowed from IsParentalControlActivityLoggingOn().

AssertWaitAllowed() is not required for code that don't wait
on base synchronization primitives (i.e. code that calls methods
listed above the declaration of TaskTraits::WithBaseSyncPrimitives()).

BUG=675660
Review-Url: https://codereview.chromium.org/2617833004
Cr-Commit-Position: refs/heads/master@{#442341}
Committed: https://chromium.googlesource.com/chromium/src/+/5d86f04df6c366289513eb7c5e113b4942ccd6f2

[fdoray, 2017-01-06 18:45:31]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2017-01-06 18:45:32]

PTAL

[gab, 2017-01-09 18:09:16]

Re CL description: 

"AssertWaitAllowed() should only be used from methods listed
above the declaration of TaskTraits::WithBaseSyncPrimitives()."

if we want this to be true, we need to update AssertWaitAllowed()'s
documentation. Until then we can say we're removing AssertWaitAllowed() because
it's not required for tasks that aren't using synchronization primitives.

[gab, 2017-01-09 18:09:23]

On 2017/01/09 18:09:16, gab wrote:
> Re CL description: 
> 
> "AssertWaitAllowed() should only be used from methods listed
> above the declaration of TaskTraits::WithBaseSyncPrimitives()."
> 
> if we want this to be true, we need to update AssertWaitAllowed()'s
> documentation. Until then we can say we're removing AssertWaitAllowed()
because
> it's not required for tasks that aren't using synchronization primitives.

lgtm otherwise

[fdoray, 2017-01-09 18:58:30]

Description was changed from

==========
Remove AssertWaitAllowed from IsParentalControlActivityLoggingOn().

AssertWaitAllowed() should only be used from methods listed
above the declaration of TaskTraits::WithBaseSyncPrimitives().

BUG=675660
==========

to

==========
Remove AssertWaitAllowed from IsParentalControlActivityLoggingOn().

AssertWaitAllowed() is not required for methods other than
those listed above the declaration of TaskTraits::WithBaseSyncPrimitives().

BUG=675660
==========

[fdoray, 2017-01-09 18:58:34]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-01-09 18:58:41]

On 2017/01/09 18:09:23, gab wrote:
> On 2017/01/09 18:09:16, gab wrote:
> > Re CL description: 
> > 
> > "AssertWaitAllowed() should only be used from methods listed
> > above the declaration of TaskTraits::WithBaseSyncPrimitives()."
> > 
> > if we want this to be true, we need to update AssertWaitAllowed()'s
> > documentation. Until then we can say we're removing AssertWaitAllowed()
> because
> > it's not required for tasks that aren't using synchronization primitives.
> 
> lgtm otherwise

done.

[fdoray, 2017-01-09 18:59:08]

The CQ bit was unchecked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-01-09 18:59:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-01-09 18:59:51]

Description was changed from

==========
Remove AssertWaitAllowed from IsParentalControlActivityLoggingOn().

AssertWaitAllowed() is not required for methods other than
those listed above the declaration of TaskTraits::WithBaseSyncPrimitives().

BUG=675660
==========

to

==========
Remove AssertWaitAllowed from IsParentalControlActivityLoggingOn().

AssertWaitAllowed() is not required for code that don't wait
on base synchronization primitives (i.e. code that calls methods
listed above the declaration of TaskTraits::WithBaseSyncPrimitives()).

BUG=675660
==========

[fdoray, 2017-01-09 18:59:54]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:00:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 21:06:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483988394527570, "parent_rev":
"2d40c48d8a1ba516c866d7d9a5e789eb9b011cb2", "commit_rev":
"5d86f04df6c366289513eb7c5e113b4942ccd6f2"}

[commit-bot: I haz the power, 2017-01-09 21:06:38]

Description was changed from

==========
Remove AssertWaitAllowed from IsParentalControlActivityLoggingOn().

AssertWaitAllowed() is not required for code that don't wait
on base synchronization primitives (i.e. code that calls methods
listed above the declaration of TaskTraits::WithBaseSyncPrimitives()).

BUG=675660
==========

to

==========
Remove AssertWaitAllowed from IsParentalControlActivityLoggingOn().

AssertWaitAllowed() is not required for code that don't wait
on base synchronization primitives (i.e. code that calls methods
listed above the declaration of TaskTraits::WithBaseSyncPrimitives()).

BUG=675660

Review-Url: https://codereview.chromium.org/2617833004
Cr-Commit-Position: refs/heads/master@{#442341}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d86f04df6c366289513eb7c5e11...
==========

[commit-bot: I haz the power, 2017-01-09 21:06:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d86f04df6c366289513eb7c5e11...