Issue 261783009: Use [TypeChecking=Unrestricted] for HTMLMediaElement

Issue 261783009: Use [TypeChecking=Unrestricted] for HTMLMediaElement (Closed)

Created:
6 years, 7 months ago by philipj_slow

Modified:
6 years, 7 months ago

Reviewers:
Nils Barth (inactive), acolwell GONE FROM CHROMIUM

CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, philipj_slow, gasubic, fs, eric.carlson_apple.com, watchdog-blink-watchlist_google.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, adamk+blink_chromium.org, vcarbune.chromium, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use [TypeChecking=Unrestricted] for HTMLMediaElement BUG=354298 TBR=acolwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173150

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -54 lines)			Patch
M	LayoutTests/media/video-currentTime-set2.html	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/media/video-currentTime-set2-expected.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/media/video-playbackrate.html	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/media/video-playbackrate-expected.txt	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/media/video-volume.html	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/media/video-volume-expected.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	5 chunks	+3 lines, -25 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.idl	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

LGTM (Had a WIP that did all of these, will check and ok Philip's.) Replace ...

6 years, 7 months ago (2014-05-02 00:52:27 UTC) #2

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 7 months ago (2014-05-02 00:52:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/261783009/1

6 years, 7 months ago (2014-05-02 00:52:52 UTC) #4

Message was sent while issue was closed.

Change committed as 173150

Expand Messages | Collapse Messages