Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 261783007: Move didHandleOnloadEvents to RenderFrame. (Closed)

Created:
6 years, 7 months ago by Avi (use Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Move didHandleOnloadEvents to RenderFrame. BUG=361761 TEST=no visible change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267994

Patch Set 1 #

Total comments: 8

Patch Set 2 : nits #

Patch Set 3 : fix #

Patch Set 4 : add TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -58 lines) Patch
M content/browser/frame_host/render_frame_host_delegate.h View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 3 chunks +11 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 8 chunks +19 lines, -17 lines 0 comments Download
M content/common/frame_messages.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
Avi (use Gerrit)
6 years, 7 months ago (2014-05-01 20:31:14 UTC) #1
nasko
LGTM with a few nits. https://codereview.chromium.org/261783007/diff/1/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/261783007/diff/1/content/browser/frame_host/render_frame_host_impl.cc#newcode362 content/browser/frame_host/render_frame_host_impl.cc:362: int32 page_id) { nit: ...
6 years, 7 months ago (2014-05-01 20:42:15 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/261783007/diff/1/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/261783007/diff/1/content/browser/frame_host/render_frame_host_impl.cc#newcode362 content/browser/frame_host/render_frame_host_impl.cc:362: int32 page_id) { On 2014/05/01 20:42:16, nasko wrote: > ...
6 years, 7 months ago (2014-05-01 21:04:16 UTC) #3
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 7 months ago (2014-05-01 21:04:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/261783007/20001
6 years, 7 months ago (2014-05-01 21:05:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 22:08:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 22:08:49 UTC) #7
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 7 months ago (2014-05-02 16:27:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/261783007/40001
6 years, 7 months ago (2014-05-02 16:27:52 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 16:44:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 16:44:24 UTC) #11
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 7 months ago (2014-05-02 18:06:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/261783007/40001
6 years, 7 months ago (2014-05-02 18:06:31 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 18:38:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 18:38:25 UTC) #15
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 7 months ago (2014-05-02 18:44:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/261783007/60001
6 years, 7 months ago (2014-05-02 18:44:40 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:01:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:01:14 UTC) #19
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 7 months ago (2014-05-02 20:03:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/261783007/60001
6 years, 7 months ago (2014-05-02 20:03:35 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:27:01 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:27:02 UTC) #23
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 7 months ago (2014-05-02 21:13:53 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/261783007/60001
6 years, 7 months ago (2014-05-02 21:16:56 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 21:32:52 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 21:32:53 UTC) #27
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 7 months ago (2014-05-03 00:09:36 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/261783007/60001
6 years, 7 months ago (2014-05-03 00:10:03 UTC) #29
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 00:54:03 UTC) #30
Message was sent while issue was closed. 
Change committed as 267994

Powered by Google App Engine
This is Rietveld 408576698