content/browser/web_contents/web_contents_impl.h - Issue 261783007: Move didHandleOnloadEvents to RenderFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 261783007: Move didHandleOnloadEvents to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add TODOs Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 9e456b7622fcc68a8339f97b936ee93c1e8047c4..0482083d204a329d492b09c2cb7f648b4b02ccdd 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -328,18 +328,20 @@ class CONTENT_EXPORT WebContentsImpl

virtual void WorkerCrashed(RenderFrameHost* render_frame_host) OVERRIDE;

virtual void ShowContextMenu(RenderFrameHost* render_frame_host,

const ContextMenuParams& params) OVERRIDE;

- virtual void RunJavaScriptMessage(RenderFrameHost* rfh,

+ virtual void RunJavaScriptMessage(RenderFrameHost* render_frame_host,

const base::string16& message,

const base::string16& default_prompt,

const GURL& frame_url,

JavaScriptMessageType type,

IPC::Message* reply_msg) OVERRIDE;

- virtual void RunBeforeUnloadConfirm(RenderFrameHost* rfh,

+ virtual void RunBeforeUnloadConfirm(RenderFrameHost* render_frame_host,

const base::string16& message,

bool is_reload,

IPC::Message* reply_msg) OVERRIDE;

virtual void DidAccessInitialDocument() OVERRIDE;

virtual void DidDisownOpener(RenderFrameHost* render_frame_host) OVERRIDE;

+ virtual void DocumentOnLoadCompleted(RenderFrameHost* render_frame_host,

+ int32 page_id) OVERRIDE;

virtual WebContents* GetAsWebContents() OVERRIDE;

virtual bool IsNeverVisible() OVERRIDE;

@@ -373,9 +375,6 @@ class CONTENT_EXPORT WebContentsImpl

virtual void DidChangeLoadProgress(double progress) OVERRIDE;

virtual void DocumentAvailableInMainFrame(

RenderViewHost* render_view_host) OVERRIDE;

- virtual void DocumentOnLoadCompletedInMainFrame(

- RenderViewHost* render_view_host,

- int32 page_id) OVERRIDE;

virtual void RouteCloseEvent(RenderViewHost* rvh) OVERRIDE;

virtual void RouteMessageEvent(

RenderViewHost* rvh,