Turn off requirement that cross-origin top navigation be accompanied by a user gesture.

Turn off requirement that cross-origin top navigation be accompanied by a user gesture.

Replace with a console warning that this policy will be reinstated evenutally.

BUG=678328
Review-Url: https://codereview.chromium.org/2617773002
Cr-Commit-Position: refs/heads/master@{#442069}
Committed: https://chromium.googlesource.com/chromium/src/+/4ff362d26a90a400409db755aa389b1b87363da7

[Nate Chapin, 2017-01-05 21:24:38]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 21:25:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Chapin, 2017-01-05 21:25:45]

Description was changed from

==========
Turn off requirement that cross-origin top navigation be accmpanied by a user
gesture.

Replace with a console warning that this policy will be reinstated evenutally.

BUG=678328
==========

to

==========
Turn off requirement that cross-origin top navigation be accompanied by a user
gesture.

Replace with a console warning that this policy will be reinstated evenutally.

BUG=678328
==========

[Nate Chapin, 2017-01-05 21:42:21]

japhet@chromium.org changed reviewers:
+ jochen@chromium.org, rbyers@chromium.org

[Nate Chapin, 2017-01-05 21:42:21]

rbyers: PTAL

jochen: please review the content/ 1-liner (and any other parts you so desire).

[Rick Byers, 2017-01-05 21:48:33]

LGTM, thanks!

https://codereview.chromium.org/2617773002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/resources/iframe-that-performs-top-navigation-without-user-gesture.html
(right):

https://codereview.chromium.org/2617773002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/resources/iframe-that-performs-top-navigation-without-user-gesture.html:3:
The navigation should fail and this iframe should be blocked. This text
shouldn't appear.
fix the description

[commit-bot: I haz the power, 2017-01-05 23:28:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 23:28:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2017-01-06 19:56:09]

https://codereview.chromium.org/2617773002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/resources/iframe-that-performs-top-navigation-without-user-gesture.html
(right):

https://codereview.chromium.org/2617773002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/resources/iframe-that-performs-top-navigation-without-user-gesture.html:3:
The navigation should fail and this iframe should be blocked. This text
shouldn't appear.
On 2017/01/05 21:48:33, Rick Byers wrote:
> fix the description

Done.

[Nate Chapin, 2017-01-06 19:56:11]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 19:56:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-01-06 20:24:51]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2017-01-06 20:24:52]

lgtm

Content stamp

[commit-bot: I haz the power, 2017-01-06 21:56:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:56:55]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2017-01-06 22:07:30]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2017-01-06 22:07:30]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2617773002/#ps20001
(title: "Fix tests")

[commit-bot: I haz the power, 2017-01-06 22:07:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 22:12:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483740450487620,
"parent_rev": "0f17a6c232f6e4df227e3e149c6b097957151276", "commit_rev":
"4ff362d26a90a400409db755aa389b1b87363da7"}

[commit-bot: I haz the power, 2017-01-06 22:12:32]

Description was changed from

==========
Turn off requirement that cross-origin top navigation be accompanied by a user
gesture.

Replace with a console warning that this policy will be reinstated evenutally.

BUG=678328
==========

to

==========
Turn off requirement that cross-origin top navigation be accompanied by a user
gesture.

Replace with a console warning that this policy will be reinstated evenutally.

BUG=678328

Review-Url: https://codereview.chromium.org/2617773002
Cr-Commit-Position: refs/heads/master@{#442069}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ff362d26a90a400409db755aa38...
==========

[commit-bot: I haz the power, 2017-01-06 22:12:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ff362d26a90a400409db755aa38...