Issue 26176007: [InfoBar] Always close native infobars from C++ (Part I)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26176007: [InfoBar] Always close native infobars from C++ (Part I) (Closed)

Created:
7 years, 2 months ago by Miguel Garcia

Modified:
7 years, 2 months ago

Reviewers:
gone

CC:
chromium-reviews, Peter Kasting

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[InfoBar] Always close native infobars from C++ We have an ad-hoc mechanism to close infobars from java on navigations. That is only needed for java only infobars which will hopefully dissappear soon. Also remove the CloseinfoBar method which closed the java counterpart first. It's better to be consistent with how C++ does it and always close the C++ piece first. BUG=283720 TEST=All downstream tests keep passing Manual testing of the scenarios affected Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227726

Patch Set 1 #

Patch Set 2 : rebased #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -12 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/android/infobars/confirm_infobar.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/android/infobars/infobar_android.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/android/infobars/translate_infobar.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Miguel Garcia

On 2013/10/07 12:44:10, Miguel Garcia wrote: Split in two pieces so this one can be ...

7 years, 2 months ago (2013-10-07 14:52:16 UTC) #2

gone

We should let this one bake a day or so before requesting a merge so ...

7 years, 2 months ago (2013-10-07 16:38:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/26176007/7001

7 years, 2 months ago (2013-10-09 08:48:07 UTC) #5

Message was sent while issue was closed.

Change committed as 227726

Expand Messages | Collapse Messages