chrome/browser/ui/android/infobars/confirm_infobar.cc - Issue 26176007: [InfoBar] Always close native infobars from C++ (Part I)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/confirm_infobar.cc

Issue 26176007: [InfoBar] Always close native infobars from C++ (Part I) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/infobars/confirm_infobar.cc

diff --git a/chrome/browser/ui/android/infobars/confirm_infobar.cc b/chrome/browser/ui/android/infobars/confirm_infobar.cc

index 9d2aaf3db9c629e6ad351c822f9a4193ef282a80..a4919e51af3df8d3f7059a7b962dfa661f5acecc 100644

--- a/chrome/browser/ui/android/infobars/confirm_infobar.cc

+++ b/chrome/browser/ui/android/infobars/confirm_infobar.cc

@@ -70,8 +70,7 @@ void ConfirmInfoBar::ProcessButton(int action,

(action == InfoBarAndroid::ACTION_CANCEL));

if ((action == InfoBarAndroid::ACTION_OK) ?

delegate_->Accept() : delegate_->Cancel())

- // TODO(miguelg): Consider RemoveSelf(); instead.

- CloseInfoBar();

+ RemoveSelf();

}

string16 ConfirmInfoBar::GetTextFor(