Make ImeTest wait for insertion handle to be shown

Make ImeTest wait for insertion handle to be shown

The Ime test, testPastePopupShowAndHide, was flaking because of a race condition
where the paste popup menu was shown before the insertion handle was shown. This
is a problem because it allows the scenario:

1) Paste menu shown
2) Set composition
3) Insertion handle is shown

This causes the paste menu to not be hidden since setting the composition only
clears the menu by clearing the insertion handle. This CL makes setting the
composition wait for the insertion handle to be shown to guarantee this sequence:

1) Paste menu and insertion handle shown
2) Set composition
3) Insertion handle cleared
4) Paste menu hidden

BUG=661572
Review-Url: https://codereview.chromium.org/2617583003
Cr-Commit-Position: refs/heads/master@{#441971}
Committed: https://chromium.googlesource.com/chromium/src/+/37c0c94ce99fb212021274dc1a7a895649d4fc64

[amaralp, 2017-01-05 17:43:31]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 17:43:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amaralp, 2017-01-05 17:50:16]

Description was changed from

==========
Make ImeTest wait for insertion handle to be shown

BUG=661572
==========

to

==========
Make ImeTest wait for insertion handle to be shown

The Ime test, testPastePopupShowAndHide, was flaking because of a race condition
where the paste popup menu was shown before the insertion handle was shown. This
is a problem because it allows the scenario:

1) Paste menu shown
2) Set composition
3) Insertion handle is shown

This causes the paste menu to not be hidden since setting the composition only
clears the menu by clearing the insertion handle. This CL makes setting the
composition wait for the insertion handle to be shown to guarantee this
sequence:

1) Paste menu and insertion handle shown
2) Set composition
3) Insertion handle cleared
4) Paste menu hidden

BUG=661572
==========

[amaralp, 2017-01-05 17:50:37]

Description was changed from

==========
Make ImeTest wait for insertion handle to be shown

The Ime test, testPastePopupShowAndHide, was flaking because of a race condition
where the paste popup menu was shown before the insertion handle was shown. This
is a problem because it allows the scenario:

1) Paste menu shown
2) Set composition
3) Insertion handle is shown

This causes the paste menu to not be hidden since setting the composition only
clears the menu by clearing the insertion handle. This CL makes setting the
composition wait for the insertion handle to be shown to guarantee this
sequence:

1) Paste menu and insertion handle shown
2) Set composition
3) Insertion handle cleared
4) Paste menu hidden

BUG=661572
==========

to

==========
Make ImeTest wait for insertion handle to be shown

The Ime test, testPastePopupShowAndHide, was flaking because of a race condition
where the paste popup menu was shown before the insertion handle was shown. This
is a problem because it allows the scenario:

1) Paste menu shown
2) Set composition
3) Insertion handle is shown

This causes the paste menu to not be hidden since setting the composition only
clears the menu by clearing the insertion handle. This CL makes setting the
composition wait for the insertion handle to be shown to guarantee this
sequence:

1) Paste menu and insertion handle shown
2) Set composition
3) Insertion handle cleared
4) Paste menu hidden

BUG=661572
==========

[amaralp, 2017-01-05 17:51:25]

amaralp@chromium.org changed reviewers:
+ aelias@chromium.org, yabinh@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:01:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:01:34]

Dry run: This issue passed the CQ dry run.

[amaralp, 2017-01-05 18:17:32]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 18:18:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 18:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:33:45]

Dry run: This issue passed the CQ dry run.

[amaralp, 2017-01-05 18:36:21]

PTAL

[aelias_OOO_until_Jul13, 2017-01-06 01:57:49]

lgtm

[yabinh, 2017-01-06 10:38:15]

non-owner lgtm. Thanks!

[amaralp, 2017-01-06 17:42:24]

The CQ bit was checked by amaralp@chromium.org

[commit-bot: I haz the power, 2017-01-06 17:42:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 17:51:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483724544415260,
"parent_rev": "64657ddad6ba9f1c432aee54c0282b1c7aca1e73", "commit_rev":
"37c0c94ce99fb212021274dc1a7a895649d4fc64"}

[commit-bot: I haz the power, 2017-01-06 17:51:59]

Description was changed from

==========
Make ImeTest wait for insertion handle to be shown

The Ime test, testPastePopupShowAndHide, was flaking because of a race condition
where the paste popup menu was shown before the insertion handle was shown. This
is a problem because it allows the scenario:

1) Paste menu shown
2) Set composition
3) Insertion handle is shown

This causes the paste menu to not be hidden since setting the composition only
clears the menu by clearing the insertion handle. This CL makes setting the
composition wait for the insertion handle to be shown to guarantee this
sequence:

1) Paste menu and insertion handle shown
2) Set composition
3) Insertion handle cleared
4) Paste menu hidden

BUG=661572
==========

to

==========
Make ImeTest wait for insertion handle to be shown

The Ime test, testPastePopupShowAndHide, was flaking because of a race condition
where the paste popup menu was shown before the insertion handle was shown. This
is a problem because it allows the scenario:

1) Paste menu shown
2) Set composition
3) Insertion handle is shown

This causes the paste menu to not be hidden since setting the composition only
clears the menu by clearing the insertion handle. This CL makes setting the
composition wait for the insertion handle to be shown to guarantee this
sequence:

1) Paste menu and insertion handle shown
2) Set composition
3) Insertion handle cleared
4) Paste menu hidden

BUG=661572

Review-Url: https://codereview.chromium.org/2617583003
Cr-Commit-Position: refs/heads/master@{#441971}
Committed:
https://chromium.googlesource.com/chromium/src/+/37c0c94ce99fb212021274dc1a7a...
==========

[commit-bot: I haz the power, 2017-01-06 17:52:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37c0c94ce99fb212021274dc1a7a...