Don't use EXPECT_FLOAT_RECT_EQ from geometry_test_utils.h for non-gfx types.

Don't use EXPECT_FLOAT_RECT_EQ from geometry_test_utils.h for non-gfx types.

This change is needed to help the rename_to_chrome_style clang tool with
the Great Blink Rename.  Without this change, the tool would rename
blink::FloatRect::x accessor to X and consequently would rename all
references to this name (which before this CL would also include the
body of the EXPECT_FLOAT_RECT_EQ macro defined in
cc/test/geometry_test_utils.h).

BUG=678704
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617563003
Cr-Commit-Position: refs/heads/master@{#441746}
Committed: https://chromium.googlesource.com/chromium/src/+/79c766c81131835cc15ca44234a12b7faab715b6

[Łukasz Anforowicz, 2017-01-05 19:45:26]

Description was changed from

==========
Don't use EXPECT_FLOAT_RECT_EQ from geometry_test_utils.h for non-gfx types.

BUG=678704
==========

to

==========
Don't use EXPECT_FLOAT_RECT_EQ from geometry_test_utils.h for non-gfx types.

BUG=678704
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Łukasz Anforowicz, 2017-01-05 19:45:35]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 19:45:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-01-05 19:48:25]

Description was changed from

==========
Don't use EXPECT_FLOAT_RECT_EQ from geometry_test_utils.h for non-gfx types.

BUG=678704
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't use EXPECT_FLOAT_RECT_EQ from geometry_test_utils.h for non-gfx types.

This change is needed to help the rename_to_chrome_style clang tool with
the Great Blink Rename.  Without this change, the tool would rename
blink::FloatRect::x accessor to X and consequently would rename all
references to this name (which before this CL would also include the
body of the EXPECT_FLOAT_RECT_EQ macro defined in
cc/test/geometry_test_utils.h).

BUG=678704
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Łukasz Anforowicz, 2017-01-05 19:48:38]

lukasza@chromium.org changed reviewers:
+ pdr@chromium.org

[Łukasz Anforowicz, 2017-01-05 19:48:39]

pdr@, could you PTAL?

[pdr., 2017-01-05 20:21:37]

On 2017/01/05 at 19:48:39, lukasza wrote:
> pdr@, could you PTAL?

LGTM

[Łukasz Anforowicz, 2017-01-05 20:29:06]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-01-05 20:29:12]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-01-05 20:29:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 20:57:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483648152598210, "parent_rev":
"885339bf7e721e9e4d1afb2c5eb328144b9ab82f", "commit_rev":
"79c766c81131835cc15ca44234a12b7faab715b6"}

[commit-bot: I haz the power, 2017-01-05 20:58:13]

Description was changed from

==========
Don't use EXPECT_FLOAT_RECT_EQ from geometry_test_utils.h for non-gfx types.

This change is needed to help the rename_to_chrome_style clang tool with
the Great Blink Rename.  Without this change, the tool would rename
blink::FloatRect::x accessor to X and consequently would rename all
references to this name (which before this CL would also include the
body of the EXPECT_FLOAT_RECT_EQ macro defined in
cc/test/geometry_test_utils.h).

BUG=678704
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't use EXPECT_FLOAT_RECT_EQ from geometry_test_utils.h for non-gfx types.

This change is needed to help the rename_to_chrome_style clang tool with
the Great Blink Rename.  Without this change, the tool would rename
blink::FloatRect::x accessor to X and consequently would rename all
references to this name (which before this CL would also include the
body of the EXPECT_FLOAT_RECT_EQ macro defined in
cc/test/geometry_test_utils.h).

BUG=678704
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617563003
Cr-Commit-Position: refs/heads/master@{#441746}
Committed:
https://chromium.googlesource.com/chromium/src/+/79c766c81131835cc15ca44234a1...
==========

[commit-bot: I haz the power, 2017-01-05 20:58:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/79c766c81131835cc15ca44234a1...